Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MariaDB >= 10.0 compatibility #7

Closed
veritazx opened this issue Mar 20, 2019 · 1 comment
Closed

MariaDB >= 10.0 compatibility #7

veritazx opened this issue Mar 20, 2019 · 1 comment

Comments

@veritazx
Copy link
Contributor

Hi there!
It is marvelous, that you are now actively maintaining the DA.
I had contacted John Eikenberry and volunteered a year ago but was then sidetracked by my private life. I only managed to fork the Adapter and add our necessary fixes, but didn't take over and didn't put anything on PyPI.
Now for the issue:
The savepoint method checks for version compatibility based on a version string. Comparing '5.0.2' <= '10.0.1' or similar does not return True. Solution: use version tuples.
I'd like to cherrypick our solution and PR it here. Is that okay?

I'll also add another issue and will try to help with the beta testing. We have two Applications running on Py2, Z2, Plone 4 using ZMySQLDA, which will be made py3-ready in the next months and could be used for beta testing.

Thanks and bye,

Peter

@dataflake
Copy link
Member

Instead of asking please just submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants