-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new function safer_getattr_raise
#288
Conversation
…h `default` handling like `getattr`
The failing |
Has someone an idea why the I also get periodic notes that |
There is #238 to fix this but it is not completed yet. (When it works we will be back at 100 % coverage.)
This will not help.
Yes, According to zopefoundation/meta#14 the alternatives are not better. (This was some years ago maybe now is the time with better alternatives. I personally know none but this does not mean anything.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage is no problem. Running tox -e combined-coverage
locally should return 100 % coverage, but I did not try.
Michael Howitz wrote at 2024-10-1 23:36 -0700:
> Has someone an idea why the `coverage` test has failed and what to do to get it pass?
There is #238 to fix this but it is not completed yet. (When it works we will be back at 100 % coverage.)
Thank you! I will wait with the merge until #238 is completed.
|
Co-authored-by: Michael Howitz <m.howitz@minddistrict.com>
It prevents merging without special rights (which I have in principle but do not like to use unless really necessary). |
Currently no-one is activly working on #238. So super-powers might be helpful here. |
Michael is right, no one is working on #238. If you keep waiting for that this PR will never get merged. |
Currently, the main problem seems to be that the Apparently, we know that the overall coverage checks fail. Should we not disable them until the problem is fixed? |
The linting check does not answer because the branch protection rules have been changed to conform to the latest meta/config templates. This PR does not. There is no need to be concerned, it will fix itself after merging. The coverage check fails - as you can see - because coverage changed a tiny bit. I know, this is annoying and misleading, but again, nothing that should hold up this PR. |
I have changed the coveralls settings a little bit but they don't apply retroactively. I also removed the linting requirement. The linter has run - see Please merge so we can move forward if you want this in the next release. I will merge #289 tomorrow morning and then make a release. All of this is holding up a Python 3.13-compatible Zope release. |
P.S.: I re-ran the last batch of tests and coverage is green. The release-check failure is because Python 3.13 is released but support is not declared in |
Jens Vagelpohl wrote at 2024-10-9 04:04 -0700:
P.S.: I re-ran the last batch of tests and coverage is green. The release-check failure is because Python 3.13 is released but support is not declared in `setup.py`. This will fix itself after merging when I merge #289
Thank you for your support!
Merge is done.
|
Fixed #287.
safer_getattr_raise
is similar tosafer_getattr
but handles its parameterdefault
likegetattr
. In particular, it raisesAttributeError
if the attribute lookup fails and nodefault
has been provided.