Plugin Validation Failure returns 0

[awharn]

Plugin validation returns 0 regardless of whether or not validation succeeded. This is a problem for scripts, as they cannot check whether or not an installation of a plugin succeeded. This also may mask a problem if a user is attempting to install plugins in bulk, causing the error message to be buried and making it more difficult for a user to identify that a plugin is missing.

_____ Validation results for plugin '********' _____

*** CmdError: The handler for command = 'command1 (at depth = 2)' does not exist: /root/.zowe/plugins/installed/lib/node_modules/***********

*** CmdError: The handler for command = 'command2 (at depth = 2)' does not exist: /root/.zowe/plugins/installed/lib/node_modules/***********

This plugin has command errors. No plugin commands will be available.


root@test-vm:~# echo $?
0

[liuxh0]

I found out that calling params.response.console.error() does not result in an exit code greater than zero. Here are some ideas:

• The easiest way I can think of is to throw a string in the ValidateHandler's process() function to trigger a "Command Error".
  

  imperative/packages/imperative/src/plugins/cmd/validate/validate.handler.ts

  Line 47 in a6dbcc5

  public async process(params: IHandlerParameters): Promise<void> {

• An alternative is to call CommandResponse's failed() function whenever params.response.console.error() is called.
  

  imperative/packages/cmd/src/response/CommandResponse.ts

  Line 556 in a6dbcc5

  public error(message: string | Buffer, ...values: any[]): string {