Added support to view the Encoding history for MVS and USS in the History View

[KaranP25]

Proposed changes

Release Notes

Milestone:

Changelog: Added support to view the Encoding history for MVS and Dataset in the History View.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

Further comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (206bf06) to head (625f36f).

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #2776    +/-   ##
========================================
  Coverage   93.26%   93.27%            
========================================
  Files         102      102            
  Lines       10604    10618    +14     
  Branches     2202     2304   +102     
========================================
+ Hits         9890     9904    +14     
  Misses        713      713            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zFernand0]

Changes LGTM! 😋
Left a few small requests/comments 🥳

[rudyflores]

@zFernand0 I see the changelog check failing, even though the changelog seems to be in place in this PR. Do you know if this is a known issue for the check to break when changes are made specifically to our webview code?

[zFernand0]

zFernand0 I see the changelog check failing, even though the changelog seems to be in place in this PR. Do you know if this is a known issue for the check to break when changes are made specifically to our webview code?

I kind of agree that it probably doesn't need to be looking for that since it's a private package. We can let this PR just have that failing check, or add the no-changelog label so that it doesn't look for changelog-updates in new commits.

Ideally, we would enhance the checklog checker to have a flag/setting that doesn't look for changelog updates in private packages of a monorepo 😋

The issue below should help us not to forget about this:

• Monorepo: Add option to skip private packages awharn/check_changelog_action#18

[rudyflores]

Thanks for making this change, left some comments regarding some potential edits to the code changes

[KaranP25]

Thank you @zFernand0 and @rudyflores for your comments, I have now addressed them with my latest commit. Feel free to take a look and comment on anything else I might have missed.

[JillieBeanSim]

LGTM! thanks @KaranP25 for this added functionality in the edit history GUI

[zFernand0]

LGTM! 😋
Functionality works great too! 🥳

Random question:
Are we concerned that MVS and USS share the same encoding-history?

I don't think it has been a problem so far, but with this enhancement we are giving more visibility to this information.

I'm just wondering if people will find it odd that deleting an encodingHistory item on MVS also deletes it for USS 😋

[sonarqubecloud]

Quality Gate failed

Failed conditions
26.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[zFernand0]

zFernand0 I believe from what we discussed with @t1m0thyj on this setting is that we wanted them to share this setting between MVS and USS, did this change?
I originally intended for these to be independent but it seemed that we wanted to maintain them as shared between each other 🤔

Thanks for sharing! 🥳
I partially remember some of those discussions. My apologies for questioning the current implementation.
Since that's what was decided, then I'm onboard 😋
Thanks for the reminder... 🥳

[rudyflores]

Looks good to me, I did see an issue related to clicking on Encoding History in the drop down and then clicking sessions and the dropdown resizing its size which can be a little odd with all the resizing going on for the user, so we may want to work on keeping the dropdown length consistent in a follow up PR