Issue:1013 Add beforeMemberName to textbox for pasteMember()

[JillieBeanSim]

Signed-off-by: Billie Simmons 49491949+JillieBeanSim@users.noreply.github.com

Proposed changes

Copy & Paste PDS member should prefill filename field
#1013

Release Notes

Milestone: 1.13.0

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[katelynienaber]

Hey @JillieBeanSim, for some reason I am getting this error:

When trying to copy/paste a member from ISPPROF...maybe a permissions issue? I tried it with a binary and a text member, paste seems to work when pasting something into ISPPROF or between 2 of my own data sets, but not copying out of ISPPROF and pasting somewhere else.

If it is a permissions thing, is there a way to show a different error here? Since the problem probably is from MF and not from the zowe.pasteMember function.

[JillieBeanSim]

Hey @JillieBeanSim, for some reason I am getting this error:

When trying to copy/paste a member from ISPPROF...maybe a permissions issue? I tried it with a binary and a text member, paste seems to work when pasting something into ISPPROF or between 2 of my own data sets, but not copying out of ISPPROF and pasting somewhere else.

If it is a permissions thing, is there a way to show a different error here? Since the problem probably is from MF and not from the zowe.pasteMember function.

@katelynienaber this error popping up is pre-existing and seems to be the go to pop up for anything that goes wrong with copy/paste. I think it is out of scope for this PR and a new issue should be created to deal specifically with error handling for copy/paste as this PR was to only add the member name into the textbox. For the error handling of copy/paste some investigation will need to be done so we don't catch the error and output what we think it should be since the same error pops up for multiple issues whether it is a permissions error an issue with copying from one data set type to a different data set type and so on.

[JillieBeanSim]

I created the Error Handling issue for copy/paste #1209

Copy/Paste Pre-existing Error Handling is out of scope for this PR. Issue created to address it.

[lauren-li]

Since z/OSMF allows copying of a sequential data set into a PDS as a member, should we also implement the beforeMemberName prefill in that case as well? PDS member to PDS member is working great with the prefilled value, but I don't get any prefilled value for sequential data set -> PDS member:

[JillieBeanSim]

Since z/OSMF allows copying of a sequential data set into a PDS as a member, should we also implement the beforeMemberName prefill in that case as well? PDS member to PDS member is working great with the prefilled value, but I don't get any prefilled value for sequential data set -> PDS member:

with a sequential data set there is no before member name

[katelynienaber]

Looks great to me!

[lauren-li]

with a sequential data set there is no before member name

@JillieBeanSim That's a very good point. I retract the suggestion I made in my previous comment.

This PR looks good to me! All unit and expected integration tests are passing, and the functionality for prefilling the destination member name field with the name of the copied data set member appears to be working well.

Thanks @JillieBeanSim for this UX improvement!