Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue MVS Refinements #1230

Merged
merged 8 commits into from
Mar 23, 2021
Merged

Issue MVS Refinements #1230

merged 8 commits into from
Mar 23, 2021

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Mar 11, 2021

Proposed changes

This addresses issues found in:
#875 & #802 -> update Issue MVS Command the dialog text
#809 -> change the text in the Command Pallet from Zowe: Issue TSO Command which is linked to issue console command to read Zowe: Issue MVS Command

mvs-cmd-refinements

Release Notes

Milestone: 1.13.1 or higher

Changelog: Issue MVS Command updates to Command Pallet and dialog of Text Boxes when prompted for command.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

I do notice a number of failing integration tests on Master branch that deal with USS now that weren't there recently.
3) Extension Integration Tests - USS
Enter USS Pattern
should output path that match the user-provided path
4) Extension Integration Tests - USS
Saving a USS File
should download, change, and re-upload a file:
5) ussNodeActions integration test
Rename USS File
should rename a uss file:
6) USSTree Integration Tests
Tests that getChildren returns valid list of elements:
7) ZoweUSSNode Integration Tests
Testing that getChildren returns the correct Thenable<ZoweUSSNode[]>:

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim linked an issue Mar 11, 2021 that may be closed by this pull request
@JillieBeanSim JillieBeanSim self-assigned this Mar 11, 2021
@JillieBeanSim JillieBeanSim added Sprint 3 Technical Debt Includes Architecture, Code, Testing, Automation debt labels Mar 11, 2021
@JillieBeanSim JillieBeanSim added this to the 1.13.1 Release milestone Mar 16, 2021
@JillieBeanSim JillieBeanSim changed the base branch from master to v1.13.x March 16, 2021 15:54
Copy link
Contributor

@katelynienaber katelynienaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what it says on the tin :) One grammar change ^^'

@lauren-li
Copy link
Contributor

I think it should be an MVS command since it starts with a vowel sound...sorry for nitpicking XD

https://www.chicagomanualofstyle.org/qanda/data/faq/topics/Abbreviations/faq0005.html

I agree with @katelynienaber's grammar nitpicking here. :P Aside from that, this PR looks good so far, but I will test more after changes are made.

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Copy link
Contributor

@lauren-li lauren-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! All unit and expected integration tests are passing. (See end of comment for more details.) In manual testing, the dialog text we currently have for issuing an MVS command all looks updated appropriately.

Thanks @JillieBeanSim for these refinements!

~
For integration tests, I got 3 failures. Two of them have also been on master branch for a long time. The third was a timeout on Enter Pattern; should match data sets for multiple patterns, which I started getting more recently when testing various PRs. However, I occasionally also see this happen on master branch, so I wouldn't count it against this PR.

@JillieBeanSim Just curious as you are working on MVS commands - One of the two integration tests that consistently fails is Submit an MVS command - Perhaps you might have an idea of how to get it passing again? I'm ok with this being fixed in a future PR, since it is a test that is also broken on master branch, and I know you are continuing work on commands.

Copy link
Contributor

@jellypuno jellypuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thank you @JillieBeanSim

@jellypuno jellypuno merged commit 664f240 into v1.13.x Mar 23, 2021
@jellypuno jellypuno deleted the issue-mvs-refinements branch March 23, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Includes Architecture, Code, Testing, Automation debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarity the Issue Command (e.g., Issue MVS Command)
4 participants