Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ovsx #1240

Merged
merged 4 commits into from
Mar 25, 2021
Merged

Add ovsx #1240

merged 4 commits into from
Mar 25, 2021

Conversation

zFernand0
Copy link
Member

@zFernand0 zFernand0 commented Mar 16, 2021

Proposed changes

  • Update how tokens are handled for VSCode Extension deployments.
  • Add the ability to publish directly to Open-VSX

Note:
GH Secret has already been updated

Please merge this PR before the next HotFix or Enhancement.

Release Notes

Milestone: Sprint 3

Changelog: Add Open-VSX to the deployment pipeline

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
@zFernand0
Copy link
Member Author

@jellypuno jellypuno added this to the 1.13.1 Release milestone Mar 22, 2021
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
@zFernand0
Copy link
Member Author

We now have two separate secrets for open vsx and regular marketplace :)
This PR reflects those changes.

@jellypuno
Copy link
Contributor

Should this be compared against 1.13.x?

@zFernand0 zFernand0 changed the base branch from master to v1.13.x March 24, 2021 11:55
Copy link
Member

@phaumer phaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked at the code, but obviously cannot test it. I do not know much about this CI framework, but instead of installing vsce and ovsx it might be enough to run them via an npx command.

@jellypuno jellypuno merged commit d6aae63 into v1.13.x Mar 25, 2021
@jellypuno jellypuno deleted the add-ovsx branch March 25, 2021 08:27
@zFernand0 zFernand0 self-assigned this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants