Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FTP prerequisites to ReadMe #1246

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Add FTP prerequisites to ReadMe #1246

merged 3 commits into from
Mar 24, 2021

Conversation

lauren-li
Copy link
Contributor

@lauren-li lauren-li commented Mar 23, 2021

Proposed changes

Resolves #1242 ([zFTP] Add pre-requisite in readMe file). No code changes.

Release Notes

Milestone: 1.13.1

Changelog: Add z/OS FTP Plug-in for Zowe CLI as a prerequisite to Zowe Explorer Extension for FTP.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
@crawr crawr added this to the 1.13.1 Release milestone Mar 23, 2021
Copy link
Contributor

@IgorCATech IgorCATech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, @lauren-li I've just left some minor comments. Thanks for adding the prerequisites to this document :)

Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
@lauren-li
Copy link
Contributor Author

Thanks @IgorCATech for the great suggestions! I have made the proposed changes.

@lauren-li lauren-li requested a review from IgorCATech March 24, 2021 02:39
Copy link
Contributor

@katelynienaber katelynienaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change...

Copy link
Contributor

@katelynienaber katelynienaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@jellypuno jellypuno merged commit c5083c1 into v1.13.x Mar 24, 2021
@jellypuno jellypuno deleted the ftp-prereq branch March 24, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants