Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Theia 1.33.0 #2065

Merged
merged 9 commits into from
Jan 9, 2023
Merged

Updates for Theia 1.33.0 #2065

merged 9 commits into from
Jan 9, 2023

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Jan 5, 2023

Proposed changes

Updates the Theia Docker image used in CI from 1.25.0 to the latest version (currently 1.33.0). The new image is published on DockerHub and the source code is on GitHub.

  • Updated xpath locators in Theia integration tests since some element IDs have changed.
  • Fixed Mocha configuration since Archive results for Theia integration tests #2031 broke console output for Mocha tests.
  • Changed calls to vscode.workspace.getConfiguration to have a more specific scope. This works around a Theia bug, and should be more efficient than always loading all settings.

Release Notes

Milestone: 2.6.0

Changelog: updated in the PR

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 74.87% // Head: 74.90% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (a9684d8) compared to base (8ff10ee).
Patch coverage: 77.58% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2065      +/-   ##
==========================================
+ Coverage   74.87%   74.90%   +0.03%     
==========================================
  Files          63       63              
  Lines        7458     7467       +9     
  Branches     1621     1622       +1     
==========================================
+ Hits         5584     5593       +9     
  Misses       1873     1873              
  Partials        1        1              
Impacted Files Coverage Δ
packages/zowe-explorer/src/Profiles.ts 36.11% <20.00%> (+0.10%) ⬆️
packages/zowe-explorer/src/globals.ts 91.45% <33.33%> (+0.07%) ⬆️
packages/zowe-explorer/src/extension.ts 37.38% <50.00%> (ø)
packages/zowe-explorer/src/utils/TempFolder.ts 39.62% <50.00%> (-1.89%) ⬇️
packages/zowe-explorer/src/utils/SettingsConfig.ts 62.68% <77.77%> (+5.79%) ⬆️
packages/zowe-explorer/src/PersistentFilters.ts 98.09% <100.00%> (-0.04%) ⬇️
...ges/zowe-explorer/src/abstract/ZoweTreeProvider.ts 70.37% <100.00%> (+0.22%) ⬆️
...ges/zowe-explorer/src/command/MvsCommandHandler.ts 90.40% <100.00%> (ø)
...ges/zowe-explorer/src/command/TsoCommandHandler.ts 80.68% <100.00%> (ø)
packages/zowe-explorer/src/dataset/DatasetTree.ts 81.48% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @t1m0thyj for the updates to test against latest Theia

@JillieBeanSim JillieBeanSim added this to the v2.6.0 milestone Jan 9, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like your use of .split for the directValue funcs 😄

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few tests failing on Theia 😢
could we take a look at those before merging?

@zFernand0 zFernand0 merged commit 22f8ff9 into main Jan 9, 2023
@zFernand0 zFernand0 deleted the fix/update-theia-image branch January 9, 2023 18:21
@t1m0thyj t1m0thyj mentioned this pull request Jan 20, 2023
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants