Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TN3270 X PROG 753 #1020

Open
Martin-Zeithaml opened this issue Jun 28, 2024 · 7 comments
Open

TN3270 X PROG 753 #1020

Martin-Zeithaml opened this issue Jun 28, 2024 · 7 comments
Assignees
Labels
bug Something isn't working priority-medium An issue that isn't very important so it will be planned in the PI, once there are no more important terminal tn3270 TN 3270 emulator v1 v2

Comments

@Martin-Zeithaml
Copy link

Entering this screen will cause:

image

Dev console:

logger.ts:322 2024-06-28 12:34:56.789
<ZWED:> charles WARN (org.zowe.terminal.core.protocol,:) Unexpected invaild attribute type=0x7f

Bonus: And the word invaild is realy invalid.

@Martin-Zeithaml Martin-Zeithaml added bug Something isn't working new not yet triaged labels Jun 28, 2024
@1000TurquoisePogs 1000TurquoisePogs self-assigned this Jun 28, 2024
@1000TurquoisePogs 1000TurquoisePogs added terminal tn3270 TN 3270 emulator v2 v1 priority-medium An issue that isn't very important so it will be planned in the PI, once there are no more important and removed new not yet triaged labels Jun 28, 2024
@1000TurquoisePogs
Copy link
Member

If you can turn on more logging in the browser to see the protocol & network bytes, we can narrow down where this goes wrong.
https://github.com/zowe/tn3270-ng2/wiki/Loggers#developingdebugging

@Martin-Zeithaml
Copy link
Author

Martin-Zeithaml commented Jun 28, 2024

  1. QWS3270 works fine - below the "ca logo" there are fields like USER/PASSWORD/COMMAND (partially visible in buffer).
  2. The buffers seems to be the same as from TN3270 and QWS3270:

QWS buffer

+40404040 40404011 d2f24040 40404040 -        �K2      
+40404040 40404040 40404040 40404040 -                 
+2842f140 40404083 83838383 83838383 - �â1    ccccccccc
+83838383 402842f4 81818181 81818181 - cccc �â4aaaaaaaa
+81818140 81818181 81404040 40404040 - aaa aaaaa       
+40404040 40404040 11d4c240 40404040 -         �MB     
+40404040 40404040 40404040 40404040 -                 
+402842f1 40404040 40408383 83838383 -  �â1      cccccc
+83838340 40404040 2842f481 81818181 - ccc     �â4aaaaa
-81818140 40408181 81818128 427f4040 - aaa   aaaaa�â"
+40404040 40404040 4011d550 1df8c689 -          �N&�8Fi
+93934089 9540a896 a49940e4 e2c5d9c9 - ll in your USERI
+c4408195 8440d7c1 e2e2e6d6 d9c44081 - D and PASSWORD a
+95844097 9985a2a2 40c5d5e3 c5d91d70 - nd press ENTER�ř

TN3270 log

logger.ts:324 2024-06-28 14:35:50.866 <ZWED:> DEBUG (org.zowe.terminal.core.protocol,:) Set char attributes for positions=1324-1339 to <CharAttrs3270 std=0x0 color=0xf4 bgCol=0x0>
logger.ts:324 2024-06-28 14:35:50.866 <ZWED:> DEBUG (org.zowe.terminal.core.protocol,:) -- Order= {key: 40, 0x42: 127}
logger.ts:324 2024-06-28 14:35:50.866 <ZWED:> DEBUG (org.zowe.terminal.core.protocol,:) ---- Order buffer pos=1340
logger.ts:322 2024-06-28 14:35:50.866 <ZWED:> WARN (org.zowe.terminal.core.protocol,:) Unexpected invaild attribute type=0x7f

427f4040:

@1000TurquoisePogs
Copy link
Member

1000TurquoisePogs commented Jul 2, 2024

Yup - I agree with the area of the code you found being the cause of the message.
Thanks for the output. Now we need to check with the spec - what should happen?

https://archive.org/details/bitsavers_ibm3270GA2amProgrammersReference199206_26297005 may help.
It says 0x7f is in the "other" color range, and handling of it should be to follow the rules of Query Reply (Color).
Query reply happens early in the connection. Do you see that in the log?

It could be the server is sending something out of spec, or the doc I'm looking at is too old. Perhaps we can cross reference x3270 since it's also open source.

@1000TurquoisePogs
Copy link
Member

It looks like x3270 is doing the same
image
image

So.... I'm guessing 0x7f is actually just invalid, and the difference is our terminal does annoying things when an invalid byte is encountered.

@1000TurquoisePogs
Copy link
Member

I guess this alert should be removed: https://github.com/TSTerminal/TSTerm/blob/2dff6deaf4789c237909f6687289385855b17f62/src/Model3270.ts#L3410
Seems like dev code left in that will annoy users.

@Martin-Zeithaml
Copy link
Author

TSTerminal/TSTerm#43

@1000TurquoisePogs
Copy link
Member

TSTerm still is not used by the terminal, so I created another PR but I can't test. Can you?
Its hard to edit that code so I don't know if I got the right alert()

@1000TurquoisePogs 1000TurquoisePogs moved this to In Progress in WebUI planning board Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium An issue that isn't very important so it will be planned in the PI, once there are no more important terminal tn3270 TN 3270 emulator v1 v2
Projects
Status: In Progress
Development

No branches or pull requests

2 participants