-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix encoding not being used on upload file to uss #2334
Conversation
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2334 +/- ##
==========================================
+ Coverage 91.12% 91.13% +0.01%
==========================================
Files 636 636
Lines 18007 18002 -5
Branches 3758 3863 +105
==========================================
- Hits 16408 16406 -2
+ Misses 1598 1595 -3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
packages/zosfiles/__tests__/__system__/methods/upload/Upload.system.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: jace-roell <jace.roell@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this have a bugfix changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM! 😋
have a few requested changes though 😋
packages/zosfiles/__tests__/__system__/methods/upload/testfiles/encodingCheck.txt
Outdated
Show resolved
Hide resolved
I believe it's safe to ignore this sonarcloud coverage warnings. This is one of the rare occassions where they are not in sync, and I think we said we go with codecov one 😋 Sonarcloud
Codecov
|
Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jace-roell!
When testing this PR I noticed the command to upload a directory doesn't show a progress bar, so filed a separate issue for it: #2344
Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
Quality Gate failedFailed conditions |
What It Does
fix encoding not being used on upload file to uss, system test fix
Review Checklist
I certify that I have: