Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports failing to resolve in TSO SDK #2343

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Nov 1, 2024

What It Does

Fixes import of the TSO SDK failing - for an example see https://github.com/zowe/zowe-cli-ftp-plugin/actions/runs/11632171362/job/32397885930?pr=176

Also adds a lint rule to prevent accidental imports from ../src in the future.

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (23b05f1) to head (b311d01).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2343   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files         636      636           
  Lines       18002    18002           
  Branches     3827     3756   -71     
=======================================
  Hits        16406    16406           
  Misses       1595     1595           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 1, 2024

@t1m0thyj t1m0thyj merged commit b6e8882 into master Nov 4, 2024
17 of 18 checks passed
@t1m0thyj t1m0thyj deleted the fix/zostso-failing-imports branch November 4, 2024 15:27
@t1m0thyj t1m0thyj added the release-patch Indicates a patch to existing code has been applied label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Release succeeded for the master branch. 🎉

The following packages have been published:

  • npm: @zowe/imperative@8.6.2
  • npm: @zowe/cli-test-utils@8.6.2
  • npm: @zowe/core-for-zowe-sdk@8.6.2
  • npm: @zowe/zos-uss-for-zowe-sdk@8.6.2
  • npm: @zowe/provisioning-for-zowe-sdk@8.6.2
  • npm: @zowe/zos-console-for-zowe-sdk@8.6.2
  • npm: @zowe/zos-files-for-zowe-sdk@8.6.2
  • npm: @zowe/zos-logs-for-zowe-sdk@8.6.2
  • npm: @zowe/zosmf-for-zowe-sdk@8.6.2
  • npm: @zowe/zos-workflows-for-zowe-sdk@8.6.2
  • npm: @zowe/zos-jobs-for-zowe-sdk@8.6.2
  • npm: @zowe/zos-tso-for-zowe-sdk@8.6.2
  • npm: @zowe/cli@8.6.2

Powered by Octorelease 🚀

@t1m0thyj t1m0thyj mentioned this pull request Nov 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants