Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced #2301 to include "--help-web" commands to pass even if presence of a faulty configuration #2361

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ATorrise
Copy link
Contributor

What It Does
Enhances #2301 to include "--help-web" commands to pass even if presence of a faulty configuration.

How to Test
Mess up your configuration and run any zowe command with --help-web to ensure the web help is still triggered and a warning about your configuration appears in your terminal.

Review Checklist
I certify that I have:

Signed-off-by: Amber <amber.torrise@broadcom.com>
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (83dc71e) to head (17991e3).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2361    +/-   ##
========================================
  Coverage   91.27%   91.27%            
========================================
  Files         636      636            
  Lines       18066    18068     +2     
  Branches     3784     3894   +110     
========================================
+ Hits        16489    16491     +2     
  Misses       1576     1576            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 13, 2024

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ATorrise!

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM, thanks Amber for the fix!

@ATorrise ATorrise added the release-current Indicates that there is no new functionality being delivered label Nov 13, 2024
@ATorrise ATorrise merged commit 53cc0d0 into master Nov 13, 2024
20 checks passed
@ATorrise ATorrise deleted the help-web branch November 13, 2024 15:30
@github-actions github-actions bot removed the release-current Indicates that there is no new functionality being delivered label Nov 13, 2024
@ATorrise ATorrise mentioned this pull request Nov 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants