USS Favorited search creates extra profile node

[lauren-li]

Describe the bug
Clicking on a favorited USS search (especially more than once) creates an extra profile node. This bug is present at least as far back as ZE version 1.7.1.

To Reproduce
Steps to reproduce the behavior:

1. Favorite a search in the USS view, noting the profile name.
2. Navigate to the USS Favorites and open the profile folder containing your favorite from Step 1.
3. Click on the favorited search.
4. See that an extra profile node with the same profile name - but no search filter - is created in the USS view (outside of Favorites).

*Note: If you restart VS Code between Steps 2 and 3, you will have to click on the favorited search twice to see the issue. The first click will run the search as expected. The second click will create an extra profile node with no associated search filter - i.e. Step 4. This is what is depicted in the gif below.

Screenshots

Expected behavior
Clicking on a favorited search in USS should run the search filter on the existing profile node, or, if the profile has been hidden, it should create a node for that profile with the favorited search filter applied. At most, there should just be one node per profile (not including in the Favorites section), no matter how many times a favorited USS search has been clicked.

Desktop (please complete the following information):

• OS: Mac
• Zowe Explorer Version: 1.9.0 (Although this bug appears to be present at least as far back as ZE v1.7.1)
• (Optional) Zowe CLI Version: 6.22.0
• (Optional) Are you using Secure Credential Store? Yes

[jellypuno]

@lauren-li Is this still happening? Can we close this issue?

[lauren-li]

@jellypuno I still see this happening in Zowe Explorer v1.12.1:

[JillieBeanSim]

this is still happening