Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove favorite Profile from all the trees in THEIA and VScode not working #1144

Closed
deepali-hub opened this issue Jan 18, 2021 · 3 comments · Fixed by #1151
Closed

Remove favorite Profile from all the trees in THEIA and VScode not working #1144

deepali-hub opened this issue Jan 18, 2021 · 3 comments · Fixed by #1151
Assignees
Labels
bug Something isn't working

Comments

@deepali-hub
Copy link
Contributor

Describe the bug

To Reproduce

Steps to reproduce the behavior:

  1. Go to THEIA or VSCODE
  2. Add profile to Favorites (Under any tree Datasets/USS/Jobs)
  3. Go to Favorites
  4. Right click on favorite profile and select "Remove profile from Favorites" and select "Continue"
  5. Now you can see profile is removed from Favorite tab but refresh the page and you can see same profile in Favorites

Expected behavior

Profile should remove from favorite

Screenshots

Desktop (please complete the following information):

  • OS: Windows
  • Zowe Explorer Version: 1.11.1
  • (Optional) Zowe CLI Version:
  • (Optional) Are you using Secure Credential Store?

Additional context

@deepali-hub deepali-hub added the bug Something isn't working label Jan 18, 2021
@lauren-li lauren-li self-assigned this Jan 23, 2021
@lauren-li
Copy link
Contributor

lauren-li commented Jan 24, 2021

Thanks @deepali-hub for catching this. The logic was missing to update the settings file when the user clicked "Continue". Can you please see if this issue is fixed in PR #1151?

@deepali-hub
Copy link
Contributor Author

Thanks @lauren-li I have verified the issue in PR #1151 and now it is fixed and working as expected .

@crawr
Copy link
Contributor

crawr commented Feb 16, 2021

Fixed in v1.12.1

@crawr crawr closed this as completed Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants