Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project profiles loaded when no workspace folder is open #1802

Closed
Tracked by #1833
zFernand0 opened this issue May 12, 2022 · 2 comments · Fixed by #1939
Closed
Tracked by #1833

Project profiles loaded when no workspace folder is open #1802

zFernand0 opened this issue May 12, 2022 · 2 comments · Fixed by #1939
Assignees
Labels
bug Something isn't working good first issue Good for newcomers team-profile

Comments

@zFernand0
Copy link
Member

Describe the bug

A Team profile in ~ (e.g. /root/zowe.config.json) may be treated as a project configuration file when no workspace is open on VSCode.

To Reproduce

  1. Create a valid zowe.config.json (and schema) file in /root
  2. Open VSCode (and make sure no folders are open)
  3. Open Zowe Explorer
  4. Notice that profiles from the team config (step 1) are loaded as project profiles.

Expected behavior

No project profiles being loaded if there is no workspace open.

Screenshots

temp

Desktop (please complete the following information):

  • OS: Ubuntu 20.04
  • Zowe Explorer Version: 2.0.1
  • (Optional) Zowe CLI Version: 7.1.3
  • (Optional) Are you using Secure Credential Store? y

Additional context

The gif above is from this comment #1777 (comment), which introduces environmental variable support (more details? #1777)

@zFernand0 zFernand0 added bug Something isn't working On-Hold labels May 12, 2022
@github-actions
Copy link

Thank you for creating a bug report. If you haven't already, please ensure you have provided steps to reproduce it and as much context as possible.

@JillieBeanSim JillieBeanSim mentioned this issue Jun 24, 2022
35 tasks
@JTonda JTonda added good first issue Good for newcomers and removed On-Hold labels Jul 5, 2022
@KutluOzel-b KutluOzel-b self-assigned this Aug 30, 2022
@KutluOzel-b
Copy link
Contributor

This issue can be reproduced and same thing happens in opposite way if root directory has zowe config file. When workspace is open at the explorer instance, it behaves like a project config file and when no workspace is open it behaves like global config file. The error seems to be not related with ZOWE_CLI_HOME env variable but the order of the prioritized profiles. one can be seen at mLayers variable zowe.config.json exists parameter should be false:

image

We think not much can be done on the zowe explorer side to let imperative api know about this situation. Hence we are going to investigate it on there. @zFernand0 👍 thanks for discussion and pointing out the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers team-profile
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants