Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not specify language IDs for data sets opened in the Zowe Explorer v3 tree view #3121

Closed
benjamin-t-santos opened this issue Sep 18, 2024 · 3 comments · Fixed by #3127
Closed
Assignees
Labels
Breaking Change priority-high Production outage - this quarter or at least next quarter severity-high Bug for which there may be workaround but limits the usage of the Zowe for major use cases v3

Comments

@benjamin-t-santos
Copy link
Contributor

benjamin-t-santos commented Sep 18, 2024

Is your feature request related to a problem? Please describe.

In v2, Zowe Explorer downloaded sequential data sets to temporary on-disk storage. These downloaded files had extensions (.cbl, .pli, etc.) that allowed extenders to associate the extension with a language.

In v3, data sets are associated with a language by Zowe Explorer using the VS Code API. In onDidOpenTextDocumentof DatasetFSProvider, opened documents have their language set to the ID returned by getLanguageId(parentPath). For example, PL/I programs have their language set to pli.

Not adding a file extension prevents extenders or users from specifying their own file associations. Setting the ID forces extenders to register languages in their extension manifest with the same language IDs as Zowe Explorer to have their extension recognize data sets opened in the tree view.

Describe the solution you'd like

Zowe Explorer should not decide the language ID for data sets. Extenders should decide this - either by providing an extension for data sets opened in Zowe Explorer (as was done in v2) or by granting users access to the DatasetFSProvider to specify their own language IDs.

Describe alternatives you've considered

You could request extenders to register new languages that use the exact IDs Zowe Explorer uses. I am not sure how else to satisfy the file associations problem.

Additional context

If a solution is agreed upon, I'd be happy to help contribute.

Copy link

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 10 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@phaumer
Copy link
Member

phaumer commented Sep 18, 2024

Zowe Explorer should be completely language agnostic without trying to guess extensions or language ids.

Language ids are case sensitive and we had discussion in the past between the vendors about which variant to use to avoid conflicts. E.g. in this issue it was mentioned that Microfocus was using COBOL, IBM was using cobol and Broadcom wanted to use a different name such as Cobol or che4z.cobol (decision was not posted): IBM/zopeneditor-about#70

@phaumer phaumer added Breaking Change v3 and removed enhancement New feature or request labels Sep 18, 2024
@JTonda JTonda added priority-high Production outage - this quarter or at least next quarter severity-high Bug for which there may be workaround but limits the usage of the Zowe for major use cases labels Sep 19, 2024
@zowe-robot zowe-robot moved this from New Issues to High Priority in Zowe Explorer for VS Code Sep 19, 2024
@traeok traeok linked a pull request Sep 19, 2024 that will close this issue
15 tasks
@traeok
Copy link
Member

traeok commented Sep 19, 2024

Hi all,

After discussing with the squad, it makes the most sense to use the previous behavior from v2 where we assigned a file extension to data set resources. I've made some changes in #3127 to add those extensions back - this should allow LSPs to continue leveraging file associations as usual.

As a side note, we would like to hide the file extension from the breadcrumbs/tab for a cleaner UX, but we'll have to wait for the custom tab labels to be available for developers until we can do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change priority-high Production outage - this quarter or at least next quarter severity-high Bug for which there may be workaround but limits the usage of the Zowe for major use cases v3
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

4 participants