Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deleting a profile #332

Closed
jelaplan opened this issue Nov 26, 2019 · 8 comments · Fixed by #689
Closed

Support deleting a profile #332

jelaplan opened this issue Nov 26, 2019 · 8 comments · Fixed by #689
Assignees
Labels
Milestone

Comments

@jelaplan
Copy link

The idea is to let a user delete a profile because it is no longer needed.

Today, a user can remove a profile which removes it from the Zowe Explorer UI but the profile remains stored in the .zowe > profiles folder.
image

@jelaplan jelaplan changed the title Support editing the connection details stored in profiles Support deleting a profile Nov 26, 2019
@MikeBauerCA MikeBauerCA added this to the Backlog milestone Nov 26, 2019
@jalel01 jalel01 added the 20PI2 label Mar 11, 2020
@crawr crawr modified the milestones: Backlog, 1.5 Release Apr 1, 2020
@crawr
Copy link
Contributor

crawr commented Apr 3, 2020

@jelaplan For the function to delete profiles permanently,
Instead of the following options,

  1. via dropdown context menu
  2. via trash icon near the profile

I would like to implement it
3. via a separate "Command Palette" option. (via Ctrl+Shift+P in Windows)
delete

The next step would be to choose the profile from the list
select

The idea is just to declutter the tree as I don't see myself using this option as often as Search or Create Dataset.

@jelaplan
Copy link
Author

jelaplan commented Apr 6, 2020

@crawr I prefer option #1. You might not be surprised that I'm not a fan of burying it in the command palette with option #3. I agree that option 2 is overkill because it isn't something used often. In the context menu, we have the Issue Command option and that is also available in the command palette. I'd like to see Delete Profile done the same way.

Delete Profile

The Figma version.
https://www.figma.com/file/9iSLJIpwD9m6pWzFLjFbym/Explorer?node-id=1190%3A2486

@zdmullen
Copy link
Contributor

From the review today, shall we consider renaming "Remove profile" to "Hide profile", to help differentiate for the user what Delete does?

@jellypuno
Copy link
Contributor

tagging @jelaplan

@jelaplan
Copy link
Author

I missed the review. I asked Vaclav for the recording. Remove profile has been confused with delete profile in 2/3 usability tests I've run so yes, it seems a poor name. Hide profile seems much better.

@jelaplan
Copy link
Author

@crawr, did you add a context menu entry?

@crawr
Copy link
Contributor

crawr commented Apr 15, 2020

@crawr, did you add a context menu entry?

@jelaplan Yes, I did.

Based on the comments, the new context menu for Data Sets and USS tree profiles will be:

For Jobs:

@jellypuno
Copy link
Contributor

Hide Profile makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants