Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USS File in favorites can fail on save #793

Closed
Colin-Stone opened this issue May 12, 2020 · 2 comments
Closed

USS File in favorites can fail on save #793

Colin-Stone opened this issue May 12, 2020 · 2 comments
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. USS

Comments

@Colin-Stone
Copy link
Member

Colin-Stone commented May 12, 2020

Edge Case Regression:
Rewritten as I get closer to what is happening.

The toggle text binary is not remembered when saving an edited favorite.

Steps to recreate.

  1. Use an ASCII file that is not chtagged. In this case zosmf will assume EBCDIC and convert download. The net output is garbled.
  2. Switch to binary which will enable to contents to be viewed
  3. Modify the file
  4. Perform save
  5. Close file in editor
  6. Download the file.
  7. Open file, it's garbled. Turn back to text and all is well

Result File has been converted to EBCDIC because the binary flag has not been included during the save.

Diagnosis
The set binary method in ZoweUSS Node does not resolve the parent session reference in the same way as the saveUSSFile function in actions does. This is because the the former uses the node structure to resolve it and "actions" uses the file structure.
They have to be consistent. Maybe use the session name rather than an object to maintain these values?

@Colin-Stone Colin-Stone added the bug Something isn't working label May 12, 2020
@zdmullen
Copy link
Contributor

Depending on the route we take with this issue, it may be changed in the future with respect to what we decide to do with issue #483 , and how we handle states. Just something to keep in mind.

@zdmullen zdmullen added this to the Developer milestone May 27, 2020
@JillieBeanSim JillieBeanSim removed this from the Developer milestone Oct 6, 2022
@JillieBeanSim JillieBeanSim added priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. labels Jan 25, 2023
@JillieBeanSim
Copy link
Contributor

This enhancement has had no community activity for 12 months. The issue also has less than 10 up-votes by the community. No action on this enhancement is targeted for the next 2 calendar quarters. Therefore, this enhancement is being closed. If you feel that this enhancement should continue to be available for community up-votes, you may reopen this issue.

@JillieBeanSim JillieBeanSim closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. USS
Projects
None yet
Development

No branches or pull requests

4 participants