-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Prettier for code style #815
Comments
Currently our code base does not follow a unified code formatting style. For javascript and typescript codebases Prettier is the de-facto standard used by the majority of projects. Lets’ adopt prettier for ZOWE Explorer. |
I converted the FTP extension to eslint with prettier here. If people like this approach then we can apply the same here, but a lot of fixing will be required, which could be a good thing. https://github.com/zowe/zowe-explorer-ftp-extension/tree/add-eslint-prettier-support |
Thank you @phaumer for taking the initiative. I completely agree. Let's discuss it in your PR for the FTP plugin and once merged and tested, we can then come up with a suggestion for this repo. |
We we had a really good discussion in zowe/zowe-explorer-ftp-extension#3 and zowe/zowe-explorer-ftp-extension#4 and have a proposal for a starting point for this repo as well: https://github.com/zowe/zowe-explorer-ftp-extension Next steps:
|
Thank you @phaumer for leading this effort! I think we can break this down a bit more. The very first step can be reformatting the codebase with prettier without enabling any new linting rules. This will require only minimal manual effort. Then we can continue a separate discussion as you suggested in next steps. Perhaps in a separate issue dedicated to linting rules. |
Having a unified code style within a repository has many advantages:
The text was updated successfully, but these errors were encountered: