Skip to content

Commit

Permalink
Fixed .exit-off-canvas not closing 'overlap' menu
Browse files Browse the repository at this point in the history
Old (buggy) behavior:
---
When the menu open_type was set to 'overlap', the .exit-off-canvas
link had no effect.

Cause
---
The `.offcanvas-overlap .exit-off-canvas` selector was missing. A
selector of `.offcanvas-overlap .exit-offcanvas-menu` was where
the `.offcanvas-overlap .exit-off-canvas` selector should have been

Fix
---
- Fix selector in scss/foundation/components/_offcanvas.scss
- No documentation changes are necessary because it now conforms
  to the documentation.  The string "exit-offcanvas-menu" is not
  found anywhere else in the repository.
  • Loading branch information
regdoug committed Jul 25, 2014
1 parent f7f4c4e commit 64384fb
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions scss/foundation/components/_offcanvas.scss
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ $menu-slide: "transform 500ms ease" !default;
height: $tabbar-height;
line-height: $tabbar-line-height;

// make sure it's below the .exit-offcanvas link
// make sure it's below the .exit-off-canvas link
position: relative;
// z-index: 999;

Expand Down Expand Up @@ -338,10 +338,7 @@ $menu-slide: "transform 500ms ease" !default;
transform: none;
z-index: 1003;
}
.exit-offcanvas-menu {
@include back-link;
z-index: 1002;
}
.exit-off-canvas { @include back-link; }
}

// Older browsers
Expand Down

1 comment on commit 64384fb

@JordanWirth
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR. We want to send you an awesome Yeti t-shirt. Shoot us an email with your shirt size and address to foundation at zurb.com.

Please sign in to comment.