Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discovery): improve MQTT discovery for scene CC #3539

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jan 19, 2024

  • don't expose writable values as read-only scenes
  • give HA a hint when values are numbers and not strings

 * don't expose writable values as read-only scenes
 * give HA a hint when values are numbers and not strings
@coveralls
Copy link

coveralls commented Jan 19, 2024

Pull Request Test Coverage Report for Build 7608418678

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 22.151%

Totals Coverage Status
Change from base Build 7608408616: -0.006%
Covered Lines: 3764
Relevant Lines: 18066

💛 - Coveralls

@robertsLando
Copy link
Member

LGTM

@robertsLando robertsLando changed the title fix: improve HA MQTT discovery for scene fix(discovery): improve HA MQTT discovery for scene Jan 22, 2024
@robertsLando robertsLando changed the title fix(discovery): improve HA MQTT discovery for scene fix(discovery): improve MQTT discovery for scene CC Jan 22, 2024
@robertsLando robertsLando merged commit 383ad83 into zwave-js:master Jan 22, 2024
8 checks passed
@ccutrer ccutrer deleted the mqtt-discovery-scene branch January 22, 2024 14:37
ccutrer added a commit to ccutrer/zwave-js-ui that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants