Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network map legend should not use "Unconnected" when device route information isn't known #3562

Closed
3 tasks done
kpine opened this issue Jan 27, 2024 · 1 comment
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@kpine
Copy link
Contributor

kpine commented Jan 27, 2024

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Docker

Z-Wave JS UI version

9.8.1.04f1c76

ZwaveJS version

12.4.3

Describe the bug

The network map legend has a case for "Unconnected":

image

But that really just means the node doesn't have any known route information:

parseRouteStats(edges, controllerId, node, route, routeKind) {
if (!route) {
if (routeKind !== RouteKind.NLWR) {
// unconnected
node.color = this.legends[6].color
}
return
}

"Unconnected" gives the impression that the device is not "connected" to the Z-Wave network, but since it really means there's no known routes, it should say that instead. This can be common for battery devices where the route isn't known until the controller sends a command and then obtains the route info, and route information is not persisted in the cache. Thus it is confusing because these battery devices can be reporting info as normal, but the map suggests something is wrong.

I'd recommend using "Unknown" or something similar, like that edge does.

To Reproduce

Not sure. Probably wipe Z-Wave JS cache and restart ZUI, route info should be unavailable for battery devices.

Expected behavior

Something not as confusing as "Unconnected".

Additional context

No response

@robertsLando
Copy link
Member

I agree that label is misleading. @AlCalzone Are you ok to change that to Unknown instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants