fix: replace import.meta.url with CJS shim
#3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 11803828838Details
💛 - Coveralls |
AlCalzone
commented
Nov 12, 2024
| const pkgJson = require('./' + pkgJsonPath) | ||
| cleanPkgJson(pkgJson) | ||
| delete pkgJson.scripts | ||
| delete pkgJson.exports |
There was a problem hiding this comment.
@robertsLando Do you remember why this was necessary? This is breaking the build now, as Z-Wave JS internally makes heavy use of the exports field.
I don't see any difference in bundle size when I remove it.
There was a problem hiding this comment.
The clean was mostly for pkg side so there shouldn’t be any side effect removing it
AlCalzone
changed the title
import.meta.url with CJS shim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the new error "The argument 'filename' must be ..." reported in #3995
fixes: #3995