fix: safer subscribe (#372)

Fixes #361
zwave-js · Jan 27, 2021 · e113d76 · e113d76
1 parent 5809a03
commit e113d76
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/MqttClient.js b/lib/MqttClient.js
@@ -125,8 +125,10 @@ function onConnect () {
   this.emit('connect')
 
   if (this.toSubscribe) {
-    for (let i = 0; i < this.toSubscribe.length; i++) {
-      this.subscribe(this.toSubscribe[i])
+    // don't use toSubscribe here to prevent infinite loops when subscribe fails
+    const topics = [...this.toSubscribe]
+    for (const t of topics) {
+      this.subscribe(t)
     }
   }