Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: notification event not publiished to mqtt #1055

Merged
merged 2 commits into from
Apr 13, 2021
Merged

fix: notification event not publiished to mqtt #1055

merged 2 commits into from
Apr 13, 2021

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Apr 13, 2021 •
edited
Loading

Fixes #1044 (maybe)

@coveralls
Copy link

coveralls commented Apr 13, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 744602025

  • 0 of 16 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 17.971%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ZwaveClient.js 0 16 0.0%
Totals Coverage Status
Change from base Build 743850149: -0.006%
Covered Lines: 2030
Relevant Lines: 11585
💛 - Coveralls

@robertsLando robertsLando mentioned this pull request Apr 13, 2021
Closed
3 tasks
@robertsLando robertsLando merged commit bf8db55 into master Apr 13, 2021
@robertsLando robertsLando deleted the fix-notification branch April 13, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Basic set events not sent to mqtt anymore?
3 participants
@robertsLando @coveralls @AlCalzone