fix(ui): settings refactor, fix mesh node names #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
reviewed
Feb 4, 2021
| @@ -53,6 +53,11 @@ export default { | |||
| HomeAssistant, | |||
| NodeDetails | |||
| }, | |||
| computed: { | |||
| showHass () { | |||
| return this.node.hassDevices && Object.keys(this.node.hassDevices).length > 0 | |||
There was a problem hiding this comment.
Isn't it true that you configure hassDevices with this tab ?
In other words: shouldn't you tie the visibility of the HA tab to the mqtt being enabled OR some toggle to enable HA MQTT discovery ?
There was a problem hiding this comment.
You configure the ones I have discovered, you canno create new. If discovery is disabled no one will be created here
There was a problem hiding this comment.
BTW settings have been completely refactored now. It's more clear and easy to use the gateway as only control panel
Moved gateway table to general section
Pull Request Test Coverage Report for Build 537267691
💛 - Coveralls |
robertsLando
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @marcelveldt