Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): refactor add remove dialog #475

Merged
merged 17 commits into from
Feb 8, 2021
Merged

Conversation

jarrettv
Copy link
Collaborator

@jarrettv jarrettv commented Feb 6, 2021

Move add remove code into the DialogAddRemove.vue so ControlPanel.vue doesn't get too big.

@coveralls
Copy link

coveralls commented Feb 6, 2021

Pull Request Test Coverage Report for Build 545812888

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 20.766%

Totals Coverage Status
Change from base Build 542943065: 0.0%
Covered Lines: 1996
Relevant Lines: 9852

💛 - Coveralls

@jarrettv jarrettv changed the title feat(ui): refactor add remove ux feat(ui): refactor add remove dialog Feb 6, 2021
src/components/ControlPanel.vue Outdated Show resolved Hide resolved
src/components/dialogs/DialogAddRemove.vue Outdated Show resolved Hide resolved
src/components/dialogs/DialogAddRemove.vue Outdated Show resolved Hide resolved
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better the naming now! Thanks @jarrettv ! :)

@robertsLando robertsLando merged commit 0ecbea6 into master Feb 8, 2021
@robertsLando robertsLando deleted the feat-add-remove-ux branch February 8, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants