Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Battery devices shows as powered in mesh #546

Closed
1 of 4 tasks
jmgiaever opened this issue Feb 10, 2021 · 9 comments · Fixed by #590
Closed
1 of 4 tasks

[bug] Battery devices shows as powered in mesh #546

jmgiaever opened this issue Feb 10, 2021 · 9 comments · Fixed by #590
Assignees
Labels
bug Something isn't working

Comments

@jmgiaever
Copy link
Contributor

Version

Build/Run method

  • Docker
  • PKG
  • Manually built (git clone - npm install - npm run build )
  • Snap package

zwavejs2mqtt version: 1.1.1
zwavejs version: 6.2.0

Describe the bug

Screenshot from 2021-02-10 21-05-12

This is a Fibaro door/window sensor

Let me know which files you'll need and I'll send them to you :)

@jmgiaever jmgiaever added the bug Something isn't working label Feb 10, 2021
@robertsLando
Copy link
Member

@jmgiaever a node export would be good :)

@chrish987
Copy link

i see this as well on Aeon/Aeotec MultiSensor 6 devices. Icon is correct in the graph, but hovering over a mains node shows power source as battery in the popup.

snip

@robertsLando
Copy link
Member

Strange, so the hover shows it's battery, the icon is wrong. Could someone send me a node export?

@jmgiaever
Copy link
Contributor Author

@jmgiaever a node export would be good :)

Hi, which file would that be? HomeHex.json?

@robertsLando
Copy link
Member

robertsLando commented Feb 12, 2021

I think that could be due to this statements:

forwards: node.ready && !node.failed && node.isListening

entity.shape = entity.forwards || batlev === undefined ? 'rect' : 'battery'

Based on this it could be that forwards is evaluated to true even if the device is a battery device. @AlCalzone AFAIK a battery device cannot forword packets, so based on this what do you think it's wrong in the forwords formula, can the property isListening be true in a battery device? If so how can I evaluate the forwards correctly?

@AlCalzone
Copy link
Member

I think this is another case of that sensor thinking it is USB powered:
zwave-js/node-zwave-js#1578
zwave-js/node-zwave-js#1504

It was likely included with USB and then used with Batteries - but as far as the Z-Wave network is concerned, it looks like a listening device.

@robertsLando
Copy link
Member

Humm, I think that instead of doing that check, I will just check if battery CC exiusts, in that case I will use the battery shape...

@jmgiaever
Copy link
Contributor Author

It was likely included with USB and then used with Batteries - but as far as the Z-Wave network is concerned, it looks like a listening device.

Mine is a Fibaro Door/Window sensor 2, and it wasn't included with USB (it doesn't have any).

@robertsLando Let me know if you need files. :)

@AlCalzone
Copy link
Member

Mine is a Fibaro Door/Window sensor 2

Does zwave-js know the battery level yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants