Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hass): remove state_topic on covers for HA 2020.3.2 #881

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Conversation

varet80
Copy link
Collaborator

@varet80 varet80 commented Mar 14, 2021

Home assistant fixed a behaviour on MQTT Covers. we need to remove state_topic, as it breaks the use of MQTT Cover

Fixes #830

@coveralls
Copy link

coveralls commented Mar 14, 2021

Pull Request Test Coverage Report for Build 651307839

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 18.358%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Gateway.js 0 1 0.0%
Totals Coverage Status
Change from base Build 645364185: 0.002%
Covered Lines: 2023
Relevant Lines: 11300

💛 - Coveralls

@varet80 varet80 changed the title remove state_topic on covers - supports 2020.3.2 home assistant fix[hass]: remove state_topic on covers - supports 2020.3.2 home assistant Mar 14, 2021
@varet80 varet80 changed the title fix[hass]: remove state_topic on covers - supports 2020.3.2 home assistant fix: hass- remove state_topic on covers - supports 2020.3.2 home assistant Mar 14, 2021
@robertsLando robertsLando changed the title fix: hass- remove state_topic on covers - supports 2020.3.2 home assistant fix(hass): remove state_topic on covers for HA 2020.3.2 Mar 15, 2021
@robertsLando robertsLando merged commit 2ab3d97 into master Mar 15, 2021
@robertsLando robertsLando deleted the fix-830 branch March 15, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HASS] Covers do not work in Home Assistant 2021.3.2
3 participants