Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hass): lock payload and state #168

Merged
merged 3 commits into from
Jan 7, 2021
Merged

fix(hass): lock payload and state #168

merged 3 commits into from
Jan 7, 2021

Conversation

varet80
Copy link
Collaborator

@varet80 varet80 commented Jan 7, 2021

fixes #137

The Locks uses numbers(integers) instead of boolean with the new driver. update the payload

@coveralls
Copy link

coveralls commented Jan 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 468993300

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 25.408%
Totals Coverage Status
Change from base Build 468889932: 0.009%
Covered Lines: 1967
Relevant Lines: 7908
💛 - Coveralls

@robertsLando robertsLando changed the title fix Lock payload and state fix(hass): lock payload and state Jan 7, 2021
robertsLando
robertsLando reviewed Jan 7, 2021
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM it it works

@varet80
Copy link
Collaborator Author

varet80 commented Jan 7, 2021

Waiting for feedback from #137

@robertsLando
Copy link
Member

@billiaz Feel free to merge if the feedback is good

@robertsLando robertsLando merged commit 04952ea into master Jan 7, 2021
@robertsLando robertsLando deleted the fix-137 branch January 7, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Can’t lock/unlock Schlage BE469 (via HASS Discovery)
4 participants
@varet80 @coveralls @robertsLando @aretakisv