-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Group nodes by column values #199
Conversation
Pull Request Test Coverage Report for Build 477075538
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature! Thanks @ahochsteger !
@ahochsteger Is hot reloading working on your side? (it's not about this PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting this error on console:
Vue warn]: Property or method "nodeTableItems" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.
found in
---> <NodesTable> at src/components/nodes-table/index.vue
<VCard>
<ControlPanel> at src/components/ControlPanel.vue
<VMain>
<VApp>
<App> at src/App.vue
<Root>
It's fixed now - was a missing rename. May be related to your question about hot-reloading. This is what I just got which required me to answer with yes: $ npm run dev
> zwavejs2mqtt@1.0.0-alpha.2 dev /home/a13870/oeamtc/ws/github/zwave-js/zwavejs2mqtt-clean
> webpack serve --inline --progress --host 0.0.0.0 --config build/webpack.dev.conf.js
The command moved into a separate package: @webpack-cli/serve
Would you like to install serve? (That will run npm install -D @webpack-cli/serve) (yes/NO) : yes
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
... |
Yes but if you change something is the change hot reloaded on the page or does you need to refre3sh the page to see the new edist? I think it's something broken after the move to webpack 5 and I'm not able to find the reason. When I chage something on the code I see that the teminal show a reload but the page is not reloaded |
I think you may need to run an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Even after |
It's something broken after #155 I think |
Ok, I'll leave a comment there, as removing 'node_modules' reveals an error for me ... |
@ahochsteger If you can, give it a look. I tried to fix it some days ago without success. I had to move from webpack-dev-server to webpack serve command and everything seems working (no error shown) but no hot reloading |
Nevermind, the error I got was due to open file watches in VSCode that prevented old files from node_modules to be removed. I'm not sure, if I can help with the hot-reloading though, this is something I've not been that deep into yet. |
No worries, I'm not a webpack expert too, I will look at it next days :) thanks |
This PR adds the possibility to group the nodes by column values.
Grouping can be enabled in the column filter options:
Grouped values are shown like this (using v-data-table grouping feature):
The groups can be collapsed (click on "-") and removed (click on "X").