Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Group nodes by column values #199

Merged
merged 7 commits into from
Jan 11, 2021
Merged

Conversation

ahochsteger
Copy link
Collaborator

This PR adds the possibility to group the nodes by column values.

Grouping can be enabled in the column filter options:
image

Grouped values are shown like this (using v-data-table grouping feature):
image

The groups can be collapsed (click on "-") and removed (click on "X").

@coveralls
Copy link

coveralls commented Jan 10, 2021

Pull Request Test Coverage Report for Build 477075538

  • 0 of 30 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 25.276%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/nodes-table/nodes-table.js 0 30 0.0%
Totals Coverage Status
Change from base Build 475877614: -0.07%
Covered Lines: 1965
Relevant Lines: 7942

💛 - Coveralls

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! Thanks @ahochsteger !

src/components/nodes-table/nodes-table.js Outdated Show resolved Hide resolved
@robertsLando
Copy link
Member

@ahochsteger Is hot reloading working on your side? (it's not about this PR)

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error on console:

Vue warn]: Property or method "nodeTableItems" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.

found in

---> <NodesTable> at src/components/nodes-table/index.vue
       <VCard>
         <ControlPanel> at src/components/ControlPanel.vue
           <VMain>
             <VApp>
               <App> at src/App.vue
                 <Root>

@ahochsteger
Copy link
Collaborator Author

I'm getting this error on console:

It's fixed now - was a missing rename.
Strange that it didn't report that on my side.

May be related to your question about hot-reloading.
It seems that it's not working anymore - maybe since I updated my branch to the latest master.

This is what I just got which required me to answer with yes:

$ npm run dev

> zwavejs2mqtt@1.0.0-alpha.2 dev /home/a13870/oeamtc/ws/github/zwave-js/zwavejs2mqtt-clean
> webpack serve --inline --progress --host 0.0.0.0 --config build/webpack.dev.conf.js

The command moved into a separate package: @webpack-cli/serve
Would you like to install serve? (That will run npm install -D @webpack-cli/serve) (yes/NO) : yes
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
...

@robertsLando
Copy link
Member

This is what I just got which required me to answer with yes:

Yes but if you change something is the change hot reloaded on the page or does you need to refre3sh the page to see the new edist? I think it's something broken after the move to webpack 5 and I'm not able to find the reason. When I chage something on the code I see that the teminal show a reload but the page is not reloaded

@robertsLando
Copy link
Member

I think you may need to run an npm install command as some of your deps could be outdated

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit a2dcf32 into master Jan 11, 2021
@robertsLando robertsLando deleted the nodes-table-grouping branch January 11, 2021 09:28
@ahochsteger
Copy link
Collaborator Author

I think you may need to run an npm install command as some of your deps could be outdated

Even after npm install hot-reloading of changes in .vue files does not work anymore.
It worked on this branch before I merged the latest changes from master.

@robertsLando
Copy link
Member

It worked on this branch before I merged the latest changes from master.

It's something broken after #155 I think

@ahochsteger
Copy link
Collaborator Author

It's something broken after #155 I think

Ok, I'll leave a comment there, as removing 'node_modules' reveals an error for me ...

@robertsLando
Copy link
Member

robertsLando commented Jan 11, 2021

@ahochsteger If you can, give it a look. I tried to fix it some days ago without success. I had to move from webpack-dev-server to webpack serve command and everything seems working (no error shown) but no hot reloading

@ahochsteger
Copy link
Collaborator Author

@ahochsteger If you can, give it a look. I tried to fix it some days ago without success. I had to move from webpack-dev-server to webpack serve command and everything seems working (no error shown) but no hot reloading

Nevermind, the error I got was due to open file watches in VSCode that prevented old files from node_modules to be removed.
Closing VSCode, removing node_modules, then do 'npm install' at least does not run into an error anymore on 'npm run dev'.

I'm not sure, if I can help with the hot-reloading though, this is something I've not been that deep into yet.

@robertsLando
Copy link
Member

I'm not sure, if I can help with the hot-reloading though, this is something I've not been that deep into yet.

No worries, I'm not a webpack expert too, I will look at it next days :) thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants