Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix topics for 2gig thermostats #39

Merged
merged 1 commit into from
Dec 1, 2020
Merged

fix topics for 2gig thermostats #39

merged 1 commit into from
Dec 1, 2020

Conversation

chilicheech
Copy link
Contributor

I suspect this may be necessary for other thermostats as well, but i have no way to test the other thermostats

@coveralls
Copy link

Pull Request Test Coverage Report for Build 392633876

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.785%
Totals Coverage Status
Change from base Build 391689433: 0.0%
Covered Lines: 1827
Relevant Lines: 6474
💛 - Coveralls

robertsLando
robertsLando approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :)

@robertsLando robertsLando merged commit e1a4642 into zwave-js:master Dec 1, 2020
@chilicheech chilicheech deleted the 2gig branch December 2, 2020 22:50
@JAAlperin JAAlperin mentioned this pull request Feb 19, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chilicheech @coveralls @robertsLando