Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] v1.1.0 does not include upstream fixes for zwave-js, despite changelog #511

Closed
1 of 3 tasks
openfirmware opened this issue Feb 9, 2021 · 2 comments
Closed
1 of 3 tasks
Assignees
Labels
bug Something isn't working

Comments

@openfirmware
Copy link

Before submitting a bug please read: https://zwave-js.github.io/zwavejs2mqtt/#/troubleshooting/bug_report

Version

Build/Run method

  • Docker
  • PKG
  • Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: 1.1.0
zwavejs version: 6.1.3 (see context section)

Describe the bug

I downloaded the latest zwavejs2mqtt release (v1.1.0) so that I could test an upstream bugfix in zwave-js (link). As the v1.1.0 patch notes mention that zwave-js 6.1.3 is included, the fix should be there.

Unfortunately, it is not; when trying to update the LED parameter on the switches, it reverts to the previous value, just as it did before the fix made for zwave-js.

To Reproduce

Steps to reproduce the behavior:

  1. Download zwavejs2mqtt v1.1.0 release from GitHub to Debian/Ubuntu
  2. Unzip and copy the store directory from previous version of zwavejs2mqtt
  3. Start up zwavejs2mqtt, goto web interface
  4. Try to change Configuration Parameter 15-112-0-13 "LED Indicator Color" on Inovelli LZW31-SN switch to 170 from 42
  5. Watch it "submit", then revert to the previous value in a second

Expected behavior

The submitted value should be accepted. Last week I tried deploying zwavejs2mqtt via NodeJS with a manual patch to @zwave-js in the node_modules to fix the configuration parameter, and it did work then.

Additional context

The dependabot PR for the zwave-js 6.1.3 update did get merged for v1.1.0, and this can be seen in the package.json (permalink). However in the package-lock.json we can see that @zwave-js/core is still 6.1.1 (permalink).

I haven't tried building it locally from source and forcing an update to the package lock file so I don't know for sure if this is the cause, but it is odd!

@openfirmware openfirmware added the bug Something isn't working label Feb 9, 2021
@jcam
Copy link
Contributor

jcam commented Feb 9, 2021

As you can see here, zwave-js/core is still at version 6.1.1 even in the final 6.1.3 update of node-zwave-js, so that is not a clear indication that it hasn't actually picked up the changes.
image

@openfirmware
Copy link
Author

openfirmware commented Feb 9, 2021

Yes, that makes sense. I checked with the zwavejs2mqtt dashboard that I am running and noticed that it says App Version 1.1.0 with Zwavejs version 6.1.2, so something appears to be missing.

Edit:

I deployed zwavejs2mqtt 1.1.0.3c5f617 by the git repo instead of the GitHub release ZIP file, and it is running Zwavejs version 6.1.3 and the bugfix for the LED configuration is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants