feat(obs): Improve builtin grafana setup to have traces and logs linked #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feels like the next step for this out-of-the-box setup will be to replace |
|
Here's a screenshot of what it does:
|
lobkovilya
approved these changes
Sep 2, 2021
- Add datasources for jaeger and loki in `metrics install`.
It simplifies life after and doesn't cause any problems if there's no jaeger installed.
- Add traces to access log format
- Extract correct timestamp, mesh and add node_id as a key in promtail
- Add links between traces and access logs in grafana.
Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana
force-pushed
the
feat/traceIdLogging
branch
from
9d00273 to
c1bcc6d
Compare
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
…ed (#2716) - Add datasources for jaeger and loki in `metrics install`. It simplifies life after and doesn't cause any problems if there's no jaeger installed. - Add traces to access log format - Extract correct timestamp, mesh and add node_id as a key in promtail - Add links between traces and access logs in grafana. Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit dfe1e38)
lahabana
added a commit
that referenced
this pull request
Sep 2, 2021
…ed (#2716) (#2723) - Add datasources for jaeger and loki in `metrics install`. It simplifies life after and doesn't cause any problems if there's no jaeger installed. - Add traces to access log format - Extract correct timestamp, mesh and add node_id as a key in promtail - Add links between traces and access logs in grafana. Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit dfe1e38) Co-authored-by: Charly Molter <charly.molter@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
…ed (kumahq#2716) - Add datasources for jaeger and loki in `metrics install`. It simplifies life after and doesn't cause any problems if there's no jaeger installed. - Add traces to access log format - Extract correct timestamp, mesh and add node_id as a key in promtail - Add links between traces and access logs in grafana. Signed-off-by: Charly Molter <charly.molter@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
…ed (kumahq#2716) - Add datasources for jaeger and loki in `metrics install`. It simplifies life after and doesn't cause any problems if there's no jaeger installed. - Add traces to access log format - Extract correct timestamp, mesh and add node_id as a key in promtail - Add links between traces and access logs in grafana. Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve our out of the box grafana setup with links between logs and traces.
Full changelog
metrics install.It simplifies life after and doesn't cause any problems if there's no jaeger installed.
Documentation
TODO
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.