feat(obs): Improve builtin grafana setup to have traces and logs linked (backport #2716) #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…ed (#2716) - Add datasources for jaeger and loki in `metrics install`. It simplifies life after and doesn't cause any problems if there's no jaeger installed. - Add traces to access log format - Extract correct timestamp, mesh and add node_id as a key in promtail - Add links between traces and access logs in grafana. Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit dfe1e38)
Codecov Report
@@ Coverage Diff @@
## release-1.3 #2723 +/- ##
===============================================
+ Coverage 52.25% 52.27% +0.02%
===============================================
Files 865 865
Lines 49289 49293 +4
===============================================
+ Hits 25755 25769 +14
+ Misses 21448 21434 -14
- Partials 2086 2090 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2716 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/