Adds support for specifying specific IP for cloud provider load balan… #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR replaces #2622 |
lahabana
approved these changes
Sep 16, 2021
lahabana
requested changes
Sep 16, 2021
There was a problem hiding this comment.
Could you please sign your commit?
See: https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#sign-your-work
Also in the other PR you mentioned a possible issue with exposing multiple ports. Why is this not an issue anymore?
|
I did sign the commit with the I removed the part of the PR that made no sense due to multiple different protocols so it is no longer relevant. |
|
Yes you need the Signed-off-by bit in the commit message. |
…cers for ingress service, see: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer or https://docs.microsoft.com/en-us/azure/aks/static-ip#create-a-service-using-the-static-ip-address Signed-off-by: James D Bloom <733179+jamesdbloom@users.noreply.github.com>
|
@lahabana I've added the Signed-off-by bit now |
lahabana
approved these changes
Sep 20, 2021
|
Thx for the contrib! |
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2021
…cers for ingress service, see: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer or https://docs.microsoft.com/en-us/azure/aks/static-ip#create-a-service-using-the-static-ip-address (#2779) Signed-off-by: James D Bloom <733179+jamesdbloom@users.noreply.github.com> (cherry picked from commit a423c20)
Merged
jpeach
added a commit
that referenced
this pull request
Sep 21, 2021
Updates #2779. Signed-off-by: James Peach <james.peach@konghq.com>
jpeach
added a commit
that referenced
this pull request
Sep 21, 2021
subnetmarco
pushed a commit
that referenced
this pull request
Sep 21, 2021
…cers for ingress service, see: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer or https://docs.microsoft.com/en-us/azure/aks/static-ip#create-a-service-using-the-static-ip-address (#2779) Signed-off-by: James D Bloom <733179+jamesdbloom@users.noreply.github.com> (cherry picked from commit a423c20)
lahabana
pushed a commit
to lahabana/kuma
that referenced
this pull request
Sep 21, 2021
…cers for ingress service, see: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer or https://docs.microsoft.com/en-us/azure/aks/static-ip#create-a-service-using-the-static-ip-address (kumahq#2779) Signed-off-by: James D Bloom <733179+jamesdbloom@users.noreply.github.com>
lahabana
pushed a commit
to lahabana/kuma
that referenced
this pull request
Sep 21, 2021
Updates kumahq#2779. Signed-off-by: James Peach <james.peach@konghq.com>
jpeach
pushed a commit
that referenced
this pull request
Sep 22, 2021
…cers for ingress service, see: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer or https://docs.microsoft.com/en-us/azure/aks/static-ip#create-a-service-using-the-static-ip-address (#2779) (#2803) Signed-off-by: James D Bloom <733179+jamesdbloom@users.noreply.github.com> (cherry picked from commit a423c20) Co-authored-by: James D Bloom <733179+jamesdbloom@users.noreply.github.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
…cers for ingress service, see: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer or https://docs.microsoft.com/en-us/azure/aks/static-ip#create-a-service-using-the-static-ip-address (kumahq#2779) Signed-off-by: James D Bloom <733179+jamesdbloom@users.noreply.github.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
Updates kumahq#2779. Signed-off-by: James Peach <james.peach@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
…cers for ingress service, see: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer or https://docs.microsoft.com/en-us/azure/aks/static-ip#create-a-service-using-the-static-ip-address (kumahq#2779) Signed-off-by: James D Bloom <733179+jamesdbloom@users.noreply.github.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
Updates kumahq#2779. Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for specifying specific IP for cloud provider load balancers, see: https://kubernetes.io/docs/concepts/services-networking/service/\#loadbalancer or https://docs.microsoft.com/en-us/azure/aks/static-ip\#create-a-service-using-the-static-ip-address
Full changelog
Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.