Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for specifying specific IP for cloud provider load balancers #2622

Closed
wants to merge 5 commits into from

Conversation

jamesdbloom
Copy link
Contributor

Summary

Adds support for specifying specific IP for cloud provider load balancers, see: https://kubernetes.io/docs/concepts/services-networking/service/\#loadbalancer or https://docs.microsoft.com/en-us/azure/aks/static-ip\#create-a-service-using-the-static-ip-address

Full changelog

  • added ability to configure loadBalancerIP to for control plane service

Documentation

  • documented in deployments/charts/kuma/values.yaml

Testing

  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@jamesdbloom jamesdbloom requested a review from a team as a code owner August 21, 2021 00:30
@jpeach
Copy link
Contributor

jpeach commented Aug 22, 2021

Thanks @jamesdbloom ! Could you please sign your commit?

@jamesdbloom
Copy link
Contributor Author

I realised it does not make sense to expose the normal service via a LoadBalancer as this is not allowed when there are multiple ports with different protocols (i.e. TCP and UDP).

I will update the PR and sign my commit once I have fully finished testing our deployment with multiple zones and a global cp in AKS (Azure).

@jamesdbloom
Copy link
Contributor Author

Closing as raising new PR with signed commits and slightly improved approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants