fix(kuma-cp) Limit number of postgres connection by default #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
added 2 commits
October 1, 2021 15:50
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
|
@parkanzky Is there anything special or optimal about 50? |
@jpeach The only special consideration is that postgres defaults maximum connections to 100. Users should be able to set up a mesh + postgres using defaults without us clobbering pg, so our default needs to be less than that. I tested 50 with with 1000 DPPs on 1 CP and didn't see any pg bottlenecks. If user needs to scale postgres, then they can scale this value as well. |
subnetmarco
approved these changes
Oct 4, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2021
* fix(kuma-cp) Limit number of postgres connection by default Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * tests(kuma-cp) Fix test affected by default pg vals Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * tests(kuma-cp) Fix spacing Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> (cherry picked from commit 851bc8d)
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Oct 5, 2021
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Parkanzky paul.parkanzky@konghq.com
Summary
CP previously did not limit number of postgres connections. In our performance benchmarking, we determined this can cause significant problems when connecting large numbers of dataplanes. This is configurable via env variables, but this PR limits by default.
Full changelog
Issues resolved
Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.