fix(kuma-cp) limit number of postgres connection by default (#2866)

Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
kumahq · Oct 5, 2021 · 3b8504b · 3b8504b
1 parent 797ca41
commit 3b8504b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/pkg/api-server/config_ws_test.go b/pkg/api-server/config_ws_test.go
@@ -285,6 +285,8 @@ var _ = Describe("Config WS", func() {
               "port": 15432,
               "maxReconnectInterval": "1m0s",
               "minReconnectInterval": "10s",
+              "maxIdleConnections": 50,
+              "maxOpenConnections": 50,
               "tls": {
                 "certPath": "",
                 "keyPath": "",

diff --git a/pkg/config/app/kuma-cp/kuma-cp.defaults.yaml b/pkg/config/app/kuma-cp/kuma-cp.defaults.yaml
@@ -28,10 +28,10 @@ store:
     connectionTimeout: 5 # ENV: KUMA_STORE_POSTGRES_CONNECTION_TIMEOUT
     # Maximum number of open connections to the database
     # `0` value means number of open connections is unlimited
-    maxOpenConnections: 0 # ENV: KUMA_STORE_POSTGRES_MAX_OPEN_CONNECTIONS
+    maxOpenConnections: 50 # ENV: KUMA_STORE_POSTGRES_MAX_OPEN_CONNECTIONS
     # Maximum number of connections in the idle connection pool
     # <0 value means no idle connections and 0 means default max idle connections
-    maxIdleConnections: 0  # ENV: KUMA_STORE_POSTGRES_MAX_IDLE_CONNECTIONS
+    maxIdleConnections: 50  # ENV: KUMA_STORE_POSTGRES_MAX_IDLE_CONNECTIONS
     # TLS settings
     tls:
       # Mode of TLS connection. Available values (disable, verifyNone, verifyCa, verifyFull)

diff --git a/pkg/config/plugins/resources/postgres/config.go b/pkg/config/plugins/resources/postgres/config.go
@@ -129,7 +129,8 @@ func DefaultPostgresStoreConfig() *PostgresStoreConfig {
 		Password:             "kuma",
 		DbName:               "kuma",
 		ConnectionTimeout:    5,
-		MaxOpenConnections:   0, // number of open connections is unlimited
+		MaxOpenConnections:   50, // 0 for unlimited
+		MaxIdleConnections:   50, // 0 for unlimited
 		TLS:                  DefaultTLSPostgresStoreConfig(),
 		MinReconnectInterval: 10 * time.Second,
 		MaxReconnectInterval: 60 * time.Second,