feat(kuma-cp): add gateway support for external services #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2990 +/- ##
==========================================
- Coverage 52.25% 52.24% -0.01%
==========================================
Files 913 915 +2
Lines 52906 53002 +96
==========================================
+ Hits 27644 27692 +48
- Misses 23062 23106 +44
- Partials 2200 2204 +4
Continue to review full report at Codecov.
|
jpeach
changed the title
jpeach
changed the title
jakubdyszkiewicz
approved these changes
Oct 26, 2021
Add Gateway generator support for ExternalServvice backends. Like mesh services, ExternalService backends are selected by matching the `kuma.io/service` tag. Where the tags are ambiguous (i.e. we have both Dataplane and ExternalService resources for the same service), ExternalService takes priority. This change separates the cluster generation from the route table generation just to reduce the amount of complexity in a single generator. Signed-off-by: James Peach <james.peach@konghq.com>
Signed-off-by: James Peach <james.peach@konghq.com>
lobkovilya
reviewed
Oct 27, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
Add Gateway generator support for ExternalService backends. Like mesh services, ExternalService backends are selected by matching the `kuma.io/service` tag. Where the tags are ambiguous (i.e. we have both Dataplane and ExternalService resources for the same service), ExternalService takes priority. This change separates the cluster generation from the route table generation just to reduce the amount of complexity in a single generator. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit ad2e07d) # Conflicts: # pkg/plugins/runtime/gateway/gateway_route_generator_test.go # pkg/plugins/runtime/gateway/plugin.go # pkg/plugins/runtime/gateway/route_table_generator.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Peach james.peach@konghq.com
Summary
Add Gateway generator support for ExternalServvice backends. Like
mesh services, ExternalService backends are selected by matching
the
kuma.io/servicetag. Where the tags are ambiguous (i.e. wehave both Dataplane and ExternalService resources for the same
service), ExternalService takes priority.
This change separates the cluster generation from the route table
generation just to reduce the amount of complexity in a single generator.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.