Update with review feedback.

Signed-off-by: James Peach <james.peach@konghq.com>
kumahq · Oct 27, 2021 · 7905fc5 · 7905fc5
1 parent ed3b9a2
commit 7905fc5
Showing 1 changed file with 5 additions and 10 deletions.
diff --git a/pkg/plugins/runtime/gateway/cluster_generator.go b/pkg/plugins/runtime/gateway/cluster_generator.go
@@ -178,8 +178,9 @@ func newClusterBuilder(
 	switch protocol {
 	case core_mesh.ProtocolHTTP2, core_mesh.ProtocolGRPC:
 		builder.Configure(clusters.Http2())
-	default:
+	case core_mesh.ProtocolHTTP:
 		builder.Configure(clusters.Http())
+	default:
 	}
 
 	return builder
@@ -216,29 +217,23 @@ func makeRouteDestinations(table *route.Table) (map[string]route.Destination, er
 
 func timeoutPolicyFor(dest *route.Destination) *core_mesh.TimeoutResource {
 	if policy, ok := dest.Policies[core_mesh.TimeoutType]; ok {
-		if timeout, ok := policy.(*core_mesh.TimeoutResource); ok {
-			return timeout
-		}
+		return policy.(*core_mesh.TimeoutResource)
 	}
 
 	return nil // TODO(jpeach) default timeout policy
 }
 
 func circuitBreakerPolicyFor(dest *route.Destination) *core_mesh.CircuitBreakerResource {
 	if policy, ok := dest.Policies[core_mesh.CircuitBreakerType]; ok {
-		if breaker, ok := policy.(*core_mesh.CircuitBreakerResource); ok {
-			return breaker
-		}
+		return policy.(*core_mesh.CircuitBreakerResource)
 	}
 
 	return nil // TODO(jpeach) default breaker policy
 }
 
 func healthCheckPolicyFor(dest *route.Destination) *core_mesh.HealthCheckResource {
 	if policy, ok := dest.Policies[core_mesh.HealthCheckType]; ok {
-		if checker, ok := policy.(*core_mesh.HealthCheckResource); ok {
-			return checker
-		}
+		return policy.(*core_mesh.HealthCheckResource)
 	}
 
 	return nil // TODO(jpeach) default breaker policy