Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) check explicit service account name #3228

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

When checking if we can modify resources on Zone CP we were checking just a namespace of service account.
We should check an explicit name of a service account that is used to run Kuma CP, so it's more secure.

Issues resolved

No reported issues.

Documentation

  • No docs, internal changes only.

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #3228 (a3a8808) into master (8620ed0) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3228      +/-   ##
==========================================
- Coverage   52.40%   52.40%   -0.01%     
==========================================
  Files         928      928              
  Lines       54044    54040       -4     
==========================================
- Hits        28321    28317       -4     
- Misses      23502    23503       +1     
+ Partials     2221     2220       -1     
Impacted Files Coverage Δ
pkg/plugins/runtime/k8s/plugin.go 1.12% <0.00%> (ø)
pkg/config/plugins/runtime/k8s/config.go 86.39% <100.00%> (+0.08%) ⬆️
pkg/plugins/runtime/k8s/webhooks/validation.go 87.28% <100.00%> (-0.52%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 61.53% <0.00%> (-10.26%) ⬇️
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8620ed0...a3a8808. Read the comment docs.

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review November 24, 2021 17:11
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner November 24, 2021 17:11
@jakubdyszkiewicz jakubdyszkiewicz merged commit e94d669 into master Nov 25, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the explicit-sa branch November 25, 2021 13:51
mergify bot pushed a commit that referenced this pull request Nov 25, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit e94d669)
mergify bot added a commit that referenced this pull request Nov 25, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit e94d669)

Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants