Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) check explicit service account name (backport #3228) #3366

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 25, 2021

This is an automatic backport of pull request #3228 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit e94d669)
@mergify mergify bot requested a review from a team as a code owner November 25, 2021 13:53
@codecov-commenter
Copy link

Codecov Report

Merging #3366 (0754423) into release-1.4 (57f003d) will decrease coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.4    #3366      +/-   ##
===============================================
- Coverage        52.43%   52.41%   -0.03%     
===============================================
  Files              924      924              
  Lines            53883    53879       -4     
===============================================
- Hits             28254    28238      -16     
- Misses           23408    23424      +16     
+ Partials          2221     2217       -4     
Impacted Files Coverage Δ
pkg/plugins/runtime/k8s/plugin.go 1.12% <0.00%> (ø)
pkg/config/plugins/runtime/k8s/config.go 86.39% <100.00%> (+0.08%) ⬆️
pkg/plugins/runtime/k8s/webhooks/validation.go 87.28% <100.00%> (-0.52%) ⬇️
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
pkg/events/eventbus.go 85.18% <0.00%> (-7.41%) ⬇️
pkg/insights/resyncer.go 67.22% <0.00%> (-2.68%) ⬇️
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-2.60%) ⬇️
pkg/core/resources/model/rest/resource.go 67.94% <0.00%> (-1.29%) ⬇️
pkg/core/runtime/component/component.go 88.67% <0.00%> (+7.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f003d...0754423. Read the comment docs.

@mergify mergify bot merged commit b0b6cd1 into release-1.4 Nov 25, 2021
@mergify mergify bot deleted the mergify/bp/release-1.4/pr-3228 branch November 25, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants