Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataplane)!: disallow using 0.0.0.0 in networking.address for dp #3691

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

lahabana
Copy link
Contributor

Summary

This doesn't really makes sense, is error prone and might accidently
expose services outside of the mesh, we therefore disallow it.

Issues resolved

Fix #3640

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • [ ] Add backport-to-stable label if the code follows our backporting policy

@lahabana lahabana requested a review from a team as a code owner January 10, 2022 16:22
This doesn't really makes sense, is error prone and might accidently
expose services outside of the mesh, we therefore disallow it.

Fix kumahq#3640

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana changed the title fix! disallow using 0.0.0.0 in networking.address for dp fix(dataplane)!: disallow using 0.0.0.0 in networking.address for dp Jan 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3691 (80b295a) into master (d9a14ce) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3691      +/-   ##
==========================================
- Coverage   50.94%   50.90%   -0.05%     
==========================================
  Files         930      930              
  Lines       56487    56489       +2     
==========================================
- Hits        28780    28754      -26     
- Misses      25428    25454      +26     
- Partials     2279     2281       +2     
Impacted Files Coverage Δ
...kg/core/resources/apis/mesh/dataplane_validator.go 97.84% <100.00%> (+0.03%) ⬆️
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
pkg/core/resources/store/customizable_store.go 55.55% <0.00%> (-22.23%) ⬇️
pkg/kds/client/sink.go 59.45% <0.00%> (-8.11%) ⬇️
pkg/events/eventbus.go 85.18% <0.00%> (-7.41%) ⬇️
pkg/core/tokens/default_signing_key.go 66.66% <0.00%> (-5.56%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 61.53% <0.00%> (-5.13%) ⬇️
...s/authn/api-server/tokens/admin_token_bootstrap.go 78.00% <0.00%> (-4.00%) ⬇️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
pkg/insights/resyncer.go 71.16% <0.00%> (-2.46%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a14ce...80b295a. Read the comment docs.

@lahabana lahabana merged commit 368cf53 into kumahq:master Jan 11, 2022
@lahabana lahabana deleted the fix3640 branch March 29, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow binding dp to 0.0.0.0
3 participants