Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow binding dp to 0.0.0.0 #3640

Closed
lahabana opened this issue Jan 4, 2022 · 0 comments · Fixed by #3691
Closed

Disallow binding dp to 0.0.0.0 #3640

lahabana opened this issue Jan 4, 2022 · 0 comments · Fixed by #3691
Labels
breaking-change kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Jan 4, 2022

Description

We currently allow Dataplane#networking.address=0.0.0.0 this probably should be disallowed.

We need to think about the implication of disabling this for users.
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature breaking-change triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 4, 2022
lahabana added a commit to lahabana/kuma that referenced this issue Jan 10, 2022
@lahabana
fix! disallow using 0.0.0.0 in networking.address for dp
b4c6e55 
This doesn't really makes sense, is error prone and might accidently
expose services outside of the mesh, we therefore disallow it.

Fix kumahq#3640

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana mentioned this issue Jan 10, 2022
Merged
6 tasks
lahabana added a commit to lahabana/kuma that referenced this issue Jan 10, 2022
@lahabana
fix(dataplane)!: disallow using 0.0.0.0 in networking.address for dp
80b295a 
This doesn't really makes sense, is error prone and might accidently
expose services outside of the mesh, we therefore disallow it.

Fix kumahq#3640

Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana added a commit that referenced this issue Jan 11, 2022
@lahabana
fix(dataplane)!: disallow using 0.0.0.0 in networking.address for dp (#…
368cf53 
…3691)

This doesn't really makes sense, is error prone and might accidently
expose services outside of the mesh, we therefore disallow it.

Fix #3640

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dataplane)!: disallow using 0.0.0.0 in networking.address for dp lahabana/kuma
1 participant
@lahabana