[Hub Generated] Review request for Microsoft.Security to add version …

…stable/2019-08-01 (Azure#9979) * recos * Remove system id * spellcheck * dataSource * Rename category to control * remove provider, add couple of other fields * productName/compnent * Inherit from resource, update example * Prettier Co-authored-by: Liran Chen <lirche@microsoft.com>
00Kai0 · Oct 12, 2020 · f0a2f2e · f0a2f2e
1 parent 32f1776
commit f0a2f2e
Show file tree

Hide file tree

Showing 10 changed files with 668 additions and 2 deletions.
diff --git a/...-manager/Microsoft.Security/stable/2019-08-01/examples/IotAlertTypes/GetIoTAlertType.json b/...-manager/Microsoft.Security/stable/2019-08-01/examples/IotAlertTypes/GetIoTAlertType.json
@@ -21,7 +21,9 @@
             "If the container doesn't need to run in privileged mode, remove the privileges from the container."
           ],
           "intent": "Exploitation,Execution",
-          "vendorName": "Microsoft"
+          "vendorName": "Microsoft",
+          "productName": "Azure Security Center for IoT",
+          "productComponentName": "IoT Hub"
         }
       }
     }

diff --git a/...ager/Microsoft.Security/stable/2019-08-01/examples/IotAlertTypes/GetIoTAlertTypeList.json b/...ager/Microsoft.Security/stable/2019-08-01/examples/IotAlertTypes/GetIoTAlertTypeList.json
@@ -22,7 +22,9 @@
                 "If the container doesn't need to run in privileged mode, remove the privileges from the container."
               ],
               "intent": "Exploitation,Execution",
-              "vendorName": "Microsoft"
+              "vendorName": "Microsoft",
+              "productName": "Azure Security Center for IoT",
+              "productComponentName": "IoT Hub"
             }
           }
         ]

diff --git a/....Security/stable/2019-08-01/examples/IotRecommendationTypes/GetIoTRecommendationType.json b/....Security/stable/2019-08-01/examples/IotRecommendationTypes/GetIoTRecommendationType.json
@@ -0,0 +1,30 @@
+{
+  "parameters": {
+    "api-version": "2019-08-01",
+    "subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
+    "resourceGroupName": "myGroup",
+    "solutionName": "mySolution",
+    "iotRecommendationTypeName": "IoT_VulnerableTLSCipherSuite"
+  },
+  "responses": {
+    "200": {
+      "body": {
+        "id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/myGroup/providers/Microsoft.Security/iotSecuritySolutions/mySolution/iotRecommendationTypes/IoT_VulnerableTLSCipherSuite",
+        "name": "IoT_VulnerableTLSCipherSuite",
+        "type": "Microsoft.Security/iotSecuritySolutions/iotRecommendationTypes",
+        "properties": {
+          "recommendationDisplayName": "TLS cipher suite upgrade needed",
+          "severity": "Medium",
+          "description": "Insecure TLS configurations detected. Immediate TLS cipher suite upgrade recommended.",
+          "remediationSteps": [
+            "Upgrade your TLS cipher suite to a secure configuration. See the Guide to TLS Standards Compliance for more information."
+          ],
+          "vendorName": "Microsoft",
+          "control": "Communication between device and IoT Hub is not optimized",
+          "productName": "Azure Security Center for IoT",
+          "productComponentName": "IoT Hub"
+        }
+      }
+    }
+  }
+}
diff --git a/...urity/stable/2019-08-01/examples/IotRecommendationTypes/GetIoTRecommendationTypeList.json b/...urity/stable/2019-08-01/examples/IotRecommendationTypes/GetIoTRecommendationTypeList.json
@@ -0,0 +1,33 @@
+{
+  "parameters": {
+    "api-version": "2019-08-01",
+    "subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
+    "resourceGroupName": "myGroup",
+    "solutionName": "mySolution"
+  },
+  "responses": {
+    "200": {
+      "body": {
+        "value": [
+          {
+            "id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/myGroup/providers/Microsoft.Security/iotSecuritySolutions/mySolution/iotRecommendationTypes/IoT_VulnerableTLSCipherSuite",
+            "name": "IoT_VulnerableTLSCipherSuite",
+            "type": "Microsoft.Security/iotSecuritySolutions/iotRecommendationTypes",
+            "properties": {
+              "recommendationDisplayName": "TLS cipher suite upgrade needed",
+              "severity": "Medium",
+              "description": "Insecure TLS configurations detected. Immediate TLS cipher suite upgrade recommended.",
+              "remediationSteps": [
+                "Upgrade your TLS cipher suite to a secure configuration. See the Guide to TLS Standards Compliance for more information."
+              ],
+              "vendorName": "Microsoft",
+              "control": "Communication between device and IoT Hub is not optimized",
+              "productName": "Azure Security Center for IoT",
+              "productComponentName": "IoT Hub"
+            }
+          }
+        ]
+      }
+    }
+  }
+}
diff --git a/...icrosoft.Security/stable/2019-08-01/examples/IotRecommendations/GetIoTRecommendation.json b/...icrosoft.Security/stable/2019-08-01/examples/IotRecommendations/GetIoTRecommendation.json
@@ -0,0 +1,29 @@
+{
+  "parameters": {
+    "api-version": "2019-08-01",
+    "subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
+    "resourceGroupName": "myGroup",
+    "solutionName": "mySolution",
+    "iotRecommendationId": "903e76ff-17eb-4bac-ac8a-2bc31ab68fd8"
+  },
+  "responses": {
+    "200": {
+      "body": {
+        "name": "IoT_Baseline|device-1",
+        "properties": {
+          "recommendationType": "IoT_Baseline",
+          "deviceId": "device-1",
+          "discoveredTimeUtc": "2020-05-13T06:32:25Z",
+          "recommendationAdditionalData": {
+            "SnapshotId": "48519d58-4e35-46cd-aed5-6251af95ed50",
+            "TotalFailedRules": "7",
+            "TotalRulesFailedDuoToError": "1",
+            "TotalInformationalFailedRules": "2",
+            "TotalCriticalFailedRules": "3",
+            "TotalWarningFailedRules": "1"
+          }
+        }
+      }
+    }
+  }
+}
diff --git a/...soft.Security/stable/2019-08-01/examples/IotRecommendations/GetIoTRecommendationList.json b/...soft.Security/stable/2019-08-01/examples/IotRecommendations/GetIoTRecommendationList.json
@@ -0,0 +1,36 @@
+{
+  "parameters": {
+    "api-version": "2019-08-01",
+    "subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
+    "resourceGroupName": "myGroup",
+    "solutionName": "mySolution",
+    "recommendationType": "IoT_Baseline",
+    "$limit": 1
+  },
+  "responses": {
+    "200": {
+      "body": {
+        "value": [
+          {
+            "name": "IoT_Baseline|device-1",
+            "properties": {
+              "recommendationType": "IoT_Baseline",
+              "deviceId": "device-1",
+              "discoveredTimeUtc": "2020-05-13T06:32:25Z",
+              "recommendationAdditionalData": {
+                "SnapshotId": "48519d58-4e35-46cd-aed5-6251af95ed50",
+                "TotalFailedRules": "7",
+                "TotalRulesFailedDuoToError": "1",
+                "TotalInformationalFailedRules": "2",
+                "TotalCriticalFailedRules": "3",
+                "TotalWarningFailedRules": "1"
+              }
+            }
+          }
+        ],
+        "nextLink": "https://management.azure.com/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/myGroup/providers/Microsoft.Security/iotSecuritySolutions/mySolution/iotRecommendations?api-version=2019-08-01&recommendationType=IoT_Baseline&$limit=1&$skipToken=903e76ff-17eb-4bac-ac8a-2bc31ab68fd8",
+        "totalCount": 23
+      }
+    }
+  }
+}
diff --git a/...ication/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotAlertTypes.json b/...ication/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotAlertTypes.json
@@ -208,6 +208,18 @@
           "example": "IoTSecurity",
           "description": "The name of the alert provider or internal partner"
         },
+        "productName": {
+          "readOnly": true,
+          "type": "string",
+          "example": "Azure Security Center for IoT",
+          "description": "The name of the product which published this alert"
+        },
+        "productComponentName": {
+          "readOnly": true,
+          "type": "string",
+          "example": "IoT Hub",
+          "description": "The name of a component inside the product which generated the alert"
+        },
         "vendorName": {
           "readOnly": true,
           "type": "string",