Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ahash 0.8.6 -> 0.8.11 for stdsimd feature and Color::Unset -> Color::Primary to reflect yansi v1.0.1 #179

Closed
wants to merge 2 commits into from

Conversation

aretrosen
Copy link

@aretrosen aretrosen commented May 7, 2024

Closes #178 and #176.

@aretrosen aretrosen changed the title fix: ahash 0.8.6 -> 0.8.11 for stdsimd feature Update ahash 0.8.6 -> 0.8.11 for stdsimd feature and Color::Unset is changes to Color::Primary to reflect yansi v1.0.1 May 7, 2024
@aretrosen aretrosen changed the title Update ahash 0.8.6 -> 0.8.11 for stdsimd feature and Color::Unset is changes to Color::Primary to reflect yansi v1.0.1 Update ahash 0.8.6 -> 0.8.11 for stdsimd feature and Color::Unset -> Color::Primary to reflect yansi v1.0.1 May 7, 2024
@01mf02
Copy link
Owner

01mf02 commented May 7, 2024

Hi @aretrosen, thanks for your PR!
Unfortunately, ahash 0.8.8 increases the minimal Rust version to 1.72, whereas currently, jaq builds on at least Rust 1.64. According to tkaitchuck/aHash#227, ahash 0.8.7 is sufficient to solve the issue and does not increase MSRV, so I've made the change myself in cd728e2.
The ariadne issue has to be corrected on the ariadne side. In order to prevent unwanted side effects, I'll stick with the current ariadne for now.

@01mf02 01mf02 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure on 1.80 nightly and Windows
2 participants