Call unref on child process when destroy invoked (#100)

05nelsonm · Apr 26, 2024 · 26acb3e · 26acb3e
1 parent 520f839
commit 26acb3e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/...ess-testing/src/commonTest/kotlin/io/matthewnelson/kmp/process/testing/ProcessBaseTest.kt b/...ess-testing/src/commonTest/kotlin/io/matthewnelson/kmp/process/testing/ProcessBaseTest.kt
@@ -441,6 +441,8 @@ abstract class ProcessBaseTest {
             .args("1")
             .args("--RunAsDaemon")
             .args("0")
+            .args("--__OwningControllerProcess")
+            .args(Process.Current.pid().toString())
             .destroySignal(Signal.SIGTERM)
             .envHome()
             .stdin(Stdio.Null)

diff --git a/library/process/src/jsMain/kotlin/io/matthewnelson/kmp/process/internal/JsChildProcess.kt b/library/process/src/jsMain/kotlin/io/matthewnelson/kmp/process/internal/JsChildProcess.kt
@@ -55,4 +55,6 @@ internal external class child_process_ChildProcess: events_EventEmitter {
     internal val stdin: stream_Writable?
     internal val stdout: stream_Readable?
     internal val stderr: stream_Readable?
+
+    internal fun unref()
 }
diff --git a/library/process/src/jsMain/kotlin/io/matthewnelson/kmp/process/internal/NodeJsProcess.kt b/library/process/src/jsMain/kotlin/io/matthewnelson/kmp/process/internal/NodeJsProcess.kt
@@ -40,12 +40,16 @@ internal class NodeJsProcess internal constructor(
 ) {
 
     override fun destroy(): Process {
+        val wasDestroyed = !isDestroyed
         isDestroyed = true
 
         if (!jsProcess.killed && isAlive) {
             // TODO: check result. check error
             jsProcess.kill(destroySignal.name)
         }
+
+        if (wasDestroyed) jsProcess.unref()
+
         return this
     }