Implement account note feature for enhanced account management (#298) #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up code
Fixes coin print according to language selected Clean up code
Update libra branch version
# Conflicts: # src/lang/locales/zh_cn.json
saves accounts list sort and order preferences optimizes svelte components load
avoids wrap line on table header
soaresa
force-pushed
the
feat/account-note
branch
from
829c4f3 to
6586738
Compare
# Conflicts: # src/accountActions.ts # src/components/Nav.svelte
kalvkusk
added a commit
that referenced
this pull request
May 15, 2024
* fix: sender error after account switch (#297) * Sender error after account switch * fix: typo * Implement account note feature for enhanced account management (#298) (#299) * Changes info icon on the wallet view * Updates Cargo.lock file * Fixes balance info for different locales than en-US * Adds persistence to locale preference * Changes app name from Carpe to carpe * Inits account events on account switch * Fixes displaying events of an account off chain * Adds optimistic account switch Clean up code * Unsubscribes Miner subscriptions onDestroy * Optimizes Miner components subscriptions * UX - Adds tower state skeleton * Fixes wallet components memory leak Fixes coin print according to language selected Clean up code * Adds coin transfer - WIP * Do not notify initial account selection * Transfers coins * Coin transfer adjustments * Translates onboard and transfer buttons * Fixes modal close on success * Fixes onboard modal close onSucess * Fixes events pagination vertical alignment * Fixes check sender vs receiver addresses * Adds sent payments to be displayed on the events tab * Adds wallet skeleton Update libra branch version * Removes viewport from components to avoid vertical scroll bar * Adds lang missing keys * Adds missing language keys * Fixes printCoins for Chinese * Fix rust code getting best fullnode url * Wait for account to be loaded before showing scanning for fullnodes * Hides make whole navbar link * removes events tab * adds account note feature - WIP * improves account note feature saves accounts list sort and order preferences optimizes svelte components load * hides total balance and unlocked when there is only one account avoids wrap line on table header * removes console.log * clean warnings * assigns note to account on switch signingAccount --------- Co-authored-by: BBK <chnqbj@gmail.com> Co-authored-by: soaresa <10797037+soaresa@users.noreply.github.com>
kalvkusk
added a commit
that referenced
this pull request
May 15, 2024
* fix: sender error after account switch (#297) * Sender error after account switch * fix: typo * Implement account note feature for enhanced account management (#298) (#299) * Changes info icon on the wallet view * Updates Cargo.lock file * Fixes balance info for different locales than en-US * Adds persistence to locale preference * Changes app name from Carpe to carpe * Inits account events on account switch * Fixes displaying events of an account off chain * Adds optimistic account switch Clean up code * Unsubscribes Miner subscriptions onDestroy * Optimizes Miner components subscriptions * UX - Adds tower state skeleton * Fixes wallet components memory leak Fixes coin print according to language selected Clean up code * Adds coin transfer - WIP * Do not notify initial account selection * Transfers coins * Coin transfer adjustments * Translates onboard and transfer buttons * Fixes modal close on success * Fixes onboard modal close onSucess * Fixes events pagination vertical alignment * Fixes check sender vs receiver addresses * Adds sent payments to be displayed on the events tab * Adds wallet skeleton Update libra branch version * Removes viewport from components to avoid vertical scroll bar * Adds lang missing keys * Adds missing language keys * Fixes printCoins for Chinese * Fix rust code getting best fullnode url * Wait for account to be loaded before showing scanning for fullnodes * Hides make whole navbar link * removes events tab * adds account note feature - WIP * improves account note feature saves accounts list sort and order preferences optimizes svelte components load * hides total balance and unlocked when there is only one account avoids wrap line on table header * removes console.log * clean warnings * assigns note to account on switch signingAccount * chore: dep fix --------- Co-authored-by: BBK <chnqbj@gmail.com> Co-authored-by: soaresa <10797037+soaresa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the account note feature, addressing issue #298. This feature allows users to add personalized notes to their accounts, enhancing account management capabilities.